[BUGFIX] [Hacker Rank]: Warmup: Mini-Max Sum.

[BUGFIX] [Hacker Rank]: Warmup: A Very Big Sum.

Windows "long" type is not enough to store a very big result.

Author: Gonzalo Diaz

src/lib/exercises/include/exercises/hackerrank/warmup/a_very_big_sum.hpp

@@ -3,5 +3,5 @@
 #pragma once
 
 namespace hackerrank::warmup {
-long aVeryBigSum(const std::vector<long> &ar);
+long long aVeryBigSum(const std::vector<long> &ar);
 }

src/lib/exercises/src/hackerrank/warmup/a_very_big_sum.cpp

@@ -9,8 +9,8 @@
 
 namespace hackerrank::warmup {
 
-long aVeryBigSum(const std::vector<long> &ar) {
-  const long INIT_VALUE = 0L;
+long long aVeryBigSum(const std::vector<long> &ar) {
+  const long long INIT_VALUE = 0L;
   return std::accumulate(ar.begin(), ar.end(), INIT_VALUE);
 }
 

src/lib/exercises/src/hackerrank/warmup/mini_max_sum.cpp

@@ -17,12 +17,12 @@ std::string miniMaxSumCalculate(const std::vector<int> &arr) {
     throw std::invalid_argument("List too short. Pass at least 2 elements.");
   }
 
-  long tsum = 0;
-  long tmin = arr[0];
-  long tmax = arr[1];
+  long long tsum = 0;
+  long long tmin = arr[0];
+  long long tmax = arr[1];
 
   for (const int &value : arr) {
-    auto cvalue = (long)value;
+    auto cvalue = (long long)value;
     tsum += cvalue;
     tmin = std::min(tmin, cvalue);
     tmax = std::max(tmax, cvalue);

src/tests/unit/lib/hackerrank/warmup/a_very_big_sum.test.cpp

@@ -22,7 +22,7 @@ TEST_CASE("aVeryBigSum JSON Test Cases",
   json data = json::parse(f);
 
   for (auto testcase : data) {
-    long result = hackerrank::warmup::aVeryBigSum(testcase["input"]);
+    long long result = hackerrank::warmup::aVeryBigSum(testcase["input"]);
     CHECK(result == testcase["expected"]);
   }
 }