Skip to content

Commit ca5e37e

Browse files
committed
Ignore errors on tear down
1 parent 4441e48 commit ca5e37e

File tree

3 files changed

+26
-2
lines changed

3 files changed

+26
-2
lines changed

CONTRIBUTING.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# SingleStore Python SDK Contributing Guide
2+
3+
Fork this repo and commit your changes to the forked repo.
4+
From there make a Pull Request with your submission keeping the following in mind:
5+
6+
## Pre-commit checks on the clone of this repo
7+
8+
The CI pipeline in this repo runs a bunch of validation checks and code reformatting with pre-commit checks. If you don't install those checks in your clone of the repo, the code will likely not pass. To install the pre-commit tool in your clone run the following from your clone directory. This will force the checks before you can push.
9+
10+
```bash
11+
pip3 install pre-commit==3.7.1
12+
pre-commit install
13+
```
14+
15+
The checks run automatically when you attempt to commit, but you can run them manually as well with the following:
16+
```bash
17+
pre-commit run --all-files
18+
```

singlestoredb/tests/test_fusion.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,10 @@ def setUpClass(cls):
499499
@classmethod
500500
def tearDownClass(cls):
501501
for job_id in cls.job_ids:
502-
cls.manager.organizations.current.jobs.delete(job_id)
502+
try:
503+
cls.manager.organizations.current.jobs.delete(job_id)
504+
except Exception:
505+
pass
503506
if cls.workspace_group is not None:
504507
cls.workspace_group.terminate(force=True)
505508
cls.manager = None

singlestoredb/tests/test_management.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -931,7 +931,10 @@ def setUpClass(cls):
931931
@classmethod
932932
def tearDownClass(cls):
933933
for job_id in cls.job_ids:
934-
cls.manager.organizations.current.jobs.delete(job_id)
934+
try:
935+
cls.manager.organizations.current.jobs.delete(job_id)
936+
except Exception:
937+
pass
935938
if cls.workspace_group is not None:
936939
cls.workspace_group.terminate(force=True)
937940
cls.workspace_group = None

0 commit comments

Comments
 (0)