Skip to content

expiring-todo-comments: should not flag eslint disable comments #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vladyslav-Soldatenko wants to merge 14 commits into
base: main
Choose a base branch
from
+81 −27
Open

expiring-todo-comments: should not flag eslint disable comments #2828

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8090bcb
expiring-todo-comments: should not flag eslint disable comments
Vladyslav-Soldatenko Nov 22, 2025
d0df7af
expiring-todo-comments: use ConfigCommentParser to test for eslint di…
Vladyslav-Soldatenko Nov 22, 2025
00bf48a
create and use parse-directive helper
Vladyslav-Soldatenko Nov 22, 2025
11a71ed
remove unnessesary directives
Vladyslav-Soldatenko Nov 22, 2025
859710c
add link
Vladyslav-Soldatenko Nov 22, 2025
47e0ef6
Minor tweak
fisker Nov 23, 2025
72472ab
Update reference
fisker Nov 23, 2025
074ea48
Use `sourceCode.getDisableDirectives()`
fisker Nov 23, 2025
38ac0f5
Fix
fisker Nov 23, 2025
d62bd28
Refactor
fisker Nov 23, 2025
752fd39
Typo
fisker Nov 23, 2025
af8688e
`getLoc` once!
fisker Nov 23, 2025
632b0de
Fix BUG
fisker Nov 23, 2025
ab49dc1
Update test
fisker Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions rules/expiring-todo-comments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import {ConfigCommentParser} from '@eslint/plugin-kit';
import path from 'node:path';
import {isRegExp} from 'node:util/types';
import semver from 'semver';
Expand Down Expand Up @@ -267,6 +268,8 @@ const DEFAULT_OPTIONS = {
allowWarningComments: true,
};

let configCommentParser;

/** @param {import('eslint').Rule.RuleContext} context */
const create = context => {
const options = {
Expand Down Expand Up @@ -319,6 +322,13 @@ const create = context => {

// eslint-disable-next-line complexity
function processComment(comment) {
configCommentParser ??= new ConfigCommentParser();

const directive = configCommentParser.parseDirective(comment.value);
if (directive?.label?.startsWith('eslint')) {
return;
}

if (ignoreRegexes.some(ignore => ignore.test(comment.value))) {
return;
}
Expand Down
12 changes: 12 additions & 0 deletions test/expiring-todo-comments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,18 @@ test({
code: '// TODO [2001-01-01]: quite old',
options: [{date: '2000-01-01'}],
},
{
code: `// eslint-disable-next-line rule-to-test/expiring-todo-comments
// TODO without a date`,
options: [{allowWarningComments: false}],
},
{
code: `/* eslint-disable rule-to-test/expiring-todo-comments */
// TODO without a date
// fixme [2000-01-01]: too old'
/* eslint-enable rule-to-test/expiring-todo-comments */`,
options: [{allowWarningComments: false}],
},
],
invalid: [
{
Expand Down
Loading