expiring-todo-comments: should not flag eslint disable comments
#2828
+81
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
expiring-todo-comments: should not flag eslint disable comments
fisker
reviewed
Nov 22, 2025
Vladyslav-Soldatenko
force-pushed
the
feat/expiring-todo-eslint-directives
branch
from
7690333 to
d0df7af
Compare
fisker
reviewed
Nov 22, 2025
fisker
reviewed
Nov 22, 2025
| @@ -0,0 +1,47 @@ | |||
| import {ConfigCommentParser} from '@eslint/plugin-kit'; | |||
|
|
|||
| const ESLINT_DISABLE_DIRECTIVES = new Set([ | |||
Collaborator
There was a problem hiding this comment.
Please keep the link
// https://github.com/eslint/eslint/blob/ecd0ede7fd2ccbb4c0daf0e4732e97ea0f49db1b/lib/linter/linter.js#L509-L512
fisker
reviewed
Nov 22, 2025
Collaborator
|
@Vladyslav-Soldatenko Turns out there is an |
fisker
approved these changes
Nov 23, 2025
fisker
reviewed
Nov 23, 2025
| context.on('Program', function * () { | ||
| for (const directive of getEslintDisableDirectives(context)) { | ||
| if (directive.value) { | ||
| continue; |
Collaborator
There was a problem hiding this comment.
This is a bug, using return instead of continue, introduced by me in #2571
Author
|
Hi. Are there any plans when the fix will be merged? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #2745