marked decimal128.rs as not implemented yet. waiting for rust-lang/rfcs#3453 to be available in stable rust.

Author: simplist-coder

amqp-type/src/error.rs

@@ -8,6 +8,4 @@ pub enum AppError {
     DeserializationIllegalConstructorError(u8),
     #[error("Iterator was empty or too short.")]
     IteratorEmptyOrTooShortError,
-    #[error("Error while converting Decimal128.")]
-    Decimal128ConversionError(#[from] crate::fixed_width::decimal128::Decimal128ConversionError),
 }

amqp-type/src/fixed_width/decimal128.rs

@@ -1,39 +1,34 @@
 use bigdecimal::BigDecimal;
+use crate::error::AppError;
+use crate::serde::decode::Decode;
 
 use crate::serde::encode::{Encode, Encoded};
 
 #[derive(Hash, Eq, PartialEq)]
 pub struct Decimal128(BigDecimal);
 
+
+/**
+f128 implemented in
+https://github.com/rust-lang/rfcs/pull/3453
+implement this when it is available in stable.
+*/
 impl Encode for Decimal128 {
     fn encode(&self) -> Encoded {
         0x94.into()
     }
 }
 
-impl From<f64> for Decimal128 {
-    fn from(value: f64) -> Self {
-        Decimal128(BigDecimal::try_from(value).unwrap())
+impl Decode for Decimal128 {
+    fn can_decode(_iter: impl Iterator<Item=u8>) -> bool {
+        false // Not implemented yet
     }
-}
 
-#[derive(thiserror::Error, Debug)]
-pub enum Decimal128ConversionError {
-    #[error("Coefficient is too large for Decimal128 representation.")]
-    CoefficientTooLarge,
-    #[error("Exponent overflowed in Decimal128 representation")]
-    ExponentOverflow,
-    #[error("Exponent underflowed in Decimal128 representation")]
-    ExponentUnderflow,
+    fn try_decode(_iter: impl Iterator<Item=u8>) -> Result<Self, AppError> where Self: Sized {
+        todo!("Decimal128  type is not implemented yet")
+    }
 }
 
 #[cfg(test)]
 mod test {
-    use super::*;
-
-    #[test]
-    fn construct_decimal_128() {
-        let val: Decimal128 = 128.0.into();
-        assert_eq!(val.encode().constructor(), 0x94);
-    }
 }