Usage of junit @before annotation

Author: itERRatOR

src/test/java/com/simplesteph/kafka/GitHubSourceConnectorConfigTest.java

@@ -2,6 +2,7 @@
 
 import org.apache.kafka.common.config.ConfigDef;
 import org.apache.kafka.common.config.ConfigValue;
+import org.junit.Before;
 import org.junit.Test;
 import java.util.HashMap;
 import java.util.Map;
@@ -11,71 +12,64 @@
 public class GitHubSourceConnectorConfigTest {
 
     private ConfigDef configDef = GitHubSourceConnectorConfig.conf();
-
-    private Map<String, String> initialConfig() {
-        Map<String, String> baseProps = new HashMap<>();
-        baseProps.put(OWNER_CONFIG, "foo");
-        baseProps.put(REPO_CONFIG, "bar");
-        baseProps.put(SINCE_CONFIG, "2017-04-26T01:23:45Z");
-        baseProps.put(BATCH_SIZE_CONFIG, "100");
-        baseProps.put(TOPIC_CONFIG, "github-issues");
-        return baseProps;
+    private Map<String, String> config;
+
+    @Before
+    public void setUpInitialConfig() {
+        config = new HashMap<>();
+        config.put(OWNER_CONFIG, "foo");
+        config.put(REPO_CONFIG, "bar");
+        config.put(SINCE_CONFIG, "2017-04-26T01:23:45Z");
+        config.put(BATCH_SIZE_CONFIG, "100");
+        config.put(TOPIC_CONFIG, "github-issues");
     }
 
-
     @Test
     public void doc() {
         System.out.println(GitHubSourceConnectorConfig.conf().toRst());
     }
 
     @Test
     public void initialConfigIsValid() {
-        assert (configDef.validate(initialConfig())
+        assert (configDef.validate(config)
                 .stream()
                 .allMatch(configValue -> configValue.errorMessages().size() == 0));
     }
 
     @Test
     public void canReadConfigCorrectly() {
-        GitHubSourceConnectorConfig config = new GitHubSourceConnectorConfig(initialConfig());
+        GitHubSourceConnectorConfig config = new GitHubSourceConnectorConfig(this.config);
         config.getAuthPassword();
 
     }
 
-
     @Test
     public void validateSince() {
-        Map<String, String> config = initialConfig();
         config.put(SINCE_CONFIG, "not-a-date");
         ConfigValue configValue = configDef.validateAll(config).get(SINCE_CONFIG);
         assert (configValue.errorMessages().size() > 0);
     }
 
     @Test
     public void validateBatchSize() {
-        Map<String, String> config = initialConfig();
         config.put(BATCH_SIZE_CONFIG, "-1");
         ConfigValue configValue = configDef.validateAll(config).get(BATCH_SIZE_CONFIG);
         assert (configValue.errorMessages().size() > 0);
 
-        config = initialConfig();
         config.put(BATCH_SIZE_CONFIG, "101");
         configValue = configDef.validateAll(config).get(BATCH_SIZE_CONFIG);
         assert (configValue.errorMessages().size() > 0);
-
     }
 
     @Test
     public void validateUsername() {
-        Map<String, String> config = initialConfig();
         config.put(AUTH_USERNAME_CONFIG, "username");
         ConfigValue configValue = configDef.validateAll(config).get(AUTH_USERNAME_CONFIG);
         assert (configValue.errorMessages().size() == 0);
     }
 
     @Test
     public void validatePassword() {
-        Map<String, String> config = initialConfig();
         config.put(AUTH_PASSWORD_CONFIG, "password");
         ConfigValue configValue = configDef.validateAll(config).get(AUTH_PASSWORD_CONFIG);
         assert (configValue.errorMessages().size() == 0);