Skip to content

Commit 754f231

Browse files
author
itERRatOR
committed
Add final modifier for constants
1 parent c0b9595 commit 754f231

File tree

1 file changed

+26
-26
lines changed

1 file changed

+26
-26
lines changed

src/main/java/com/simplesteph/kafka/GitHubSchemas.java

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -6,62 +6,62 @@
66

77
public class GitHubSchemas {
88

9-
public static String NEXT_PAGE_FIELD = "next_page";
9+
public static final String NEXT_PAGE_FIELD = "next_page";
1010

1111
// Issue fields
12-
public static String OWNER_FIELD = "owner";
13-
public static String REPOSITORY_FIELD = "repository";
14-
public static String CREATED_AT_FIELD = "created_at";
15-
public static String UPDATED_AT_FIELD = "updated_at";
16-
public static String NUMBER_FIELD = "number";
17-
public static String URL_FIELD = "url";
18-
public static String HTML_URL_FIELD = "html_url";
19-
public static String TITLE_FIELD = "title";
20-
public static String STATE_FIELD = "state";
12+
public static final String OWNER_FIELD = "owner";
13+
public static final String REPOSITORY_FIELD = "repository";
14+
public static final String CREATED_AT_FIELD = "created_at";
15+
public static final String UPDATED_AT_FIELD = "updated_at";
16+
public static final String NUMBER_FIELD = "number";
17+
public static final String URL_FIELD = "url";
18+
public static final String HTML_URL_FIELD = "html_url";
19+
public static final String TITLE_FIELD = "title";
20+
public static final String STATE_FIELD = "state";
2121

2222
// User fields
23-
public static String USER_FIELD = "user";
24-
public static String USER_URL_FIELD = "url";
25-
public static String USER_HTML_URL_FIELD = "html_url";
26-
public static String USER_ID_FIELD = "id";
27-
public static String USER_LOGIN_FIELD = "login";
23+
public static final String USER_FIELD = "user";
24+
public static final String USER_URL_FIELD = "url";
25+
public static final String USER_HTML_URL_FIELD = "html_url";
26+
public static final String USER_ID_FIELD = "id";
27+
public static final String USER_LOGIN_FIELD = "login";
2828

2929
// PR fields
30-
public static String PR_FIELD = "pull_request";
31-
public static String PR_URL_FIELD = "url";
32-
public static String PR_HTML_URL_FIELD = "html_url";
30+
public static final String PR_FIELD = "pull_request";
31+
public static final String PR_URL_FIELD = "url";
32+
public static final String PR_HTML_URL_FIELD = "html_url";
3333

3434
// Schema names
35-
public static String SCHEMA_KEY = "com.simplesteph.kafka.connect.github.IssueKey";
36-
public static String SCHEMA_VALUE_ISSUE = "com.simplesteph.kafka.connect.github.IssueValue";
37-
public static String SCHEMA_VALUE_USER = "com.simplesteph.kafka.connect.github.UserValue";
38-
public static String SCHEMA_VALUE_PR = "com.simplesteph.kafka.connect.github.PrValue";
35+
public static final String SCHEMA_KEY = "com.simplesteph.kafka.connect.github.IssueKey";
36+
public static final String SCHEMA_VALUE_ISSUE = "com.simplesteph.kafka.connect.github.IssueValue";
37+
public static final String SCHEMA_VALUE_USER = "com.simplesteph.kafka.connect.github.UserValue";
38+
public static final String SCHEMA_VALUE_PR = "com.simplesteph.kafka.connect.github.PrValue";
3939

4040
// Key Schema
41-
public static Schema KEY_SCHEMA = SchemaBuilder.struct().name(SCHEMA_KEY)
41+
public static final Schema KEY_SCHEMA = SchemaBuilder.struct().name(SCHEMA_KEY)
4242
.version(1)
4343
.field(OWNER_FIELD, Schema.STRING_SCHEMA)
4444
.field(REPOSITORY_FIELD, Schema.STRING_SCHEMA)
4545
.field(NUMBER_FIELD, Schema.INT32_SCHEMA)
4646
.build();
4747

4848
// Value Schema
49-
public static Schema USER_SCHEMA = SchemaBuilder.struct().name(SCHEMA_VALUE_USER)
49+
public static final Schema USER_SCHEMA = SchemaBuilder.struct().name(SCHEMA_VALUE_USER)
5050
.version(1)
5151
.field(USER_URL_FIELD, Schema.STRING_SCHEMA)
5252
.field(USER_ID_FIELD, Schema.INT32_SCHEMA)
5353
.field(USER_LOGIN_FIELD, Schema.STRING_SCHEMA)
5454
.build();
5555

5656
// optional schema
57-
public static Schema PR_SCHEMA = SchemaBuilder.struct().name(SCHEMA_VALUE_PR)
57+
public static final Schema PR_SCHEMA = SchemaBuilder.struct().name(SCHEMA_VALUE_PR)
5858
.version(1)
5959
.field(PR_URL_FIELD, Schema.STRING_SCHEMA)
6060
.field(PR_HTML_URL_FIELD, Schema.STRING_SCHEMA)
6161
.optional()
6262
.build();
6363

64-
public static Schema VALUE_SCHEMA = SchemaBuilder.struct().name(SCHEMA_VALUE_ISSUE)
64+
public static final Schema VALUE_SCHEMA = SchemaBuilder.struct().name(SCHEMA_VALUE_ISSUE)
6565
.version(2)
6666
.field(URL_FIELD, Schema.STRING_SCHEMA)
6767
.field(TITLE_FIELD, Schema.STRING_SCHEMA)

0 commit comments

Comments
 (0)