Skip to content

Commit 58cb201

Browse files
Core java assert --> JUnit assertions
1 parent 7ce1a40 commit 58cb201

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

src/test/java/com/simplesteph/kafka/GitHubSourceConnectorConfigTest.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import java.util.Map;
99

1010
import static com.simplesteph.kafka.GitHubSourceConnectorConfig.*;
11+
import static org.junit.Assert.*;
1112

1213
public class GitHubSourceConnectorConfigTest {
1314

@@ -31,7 +32,7 @@ public void doc() {
3132

3233
@Test
3334
public void initialConfigIsValid() {
34-
assert (configDef.validate(config)
35+
assertTrue(configDef.validate(config)
3536
.stream()
3637
.allMatch(configValue -> configValue.errorMessages().size() == 0));
3738
}
@@ -47,32 +48,32 @@ public void canReadConfigCorrectly() {
4748
public void validateSince() {
4849
config.put(SINCE_CONFIG, "not-a-date");
4950
ConfigValue configValue = configDef.validateAll(config).get(SINCE_CONFIG);
50-
assert (configValue.errorMessages().size() > 0);
51+
assertTrue(configValue.errorMessages().size() > 0);
5152
}
5253

5354
@Test
5455
public void validateBatchSize() {
5556
config.put(BATCH_SIZE_CONFIG, "-1");
5657
ConfigValue configValue = configDef.validateAll(config).get(BATCH_SIZE_CONFIG);
57-
assert (configValue.errorMessages().size() > 0);
58+
assertTrue(configValue.errorMessages().size() > 0);
5859

5960
config.put(BATCH_SIZE_CONFIG, "101");
6061
configValue = configDef.validateAll(config).get(BATCH_SIZE_CONFIG);
61-
assert (configValue.errorMessages().size() > 0);
62+
assertTrue(configValue.errorMessages().size() > 0);
6263
}
6364

6465
@Test
6566
public void validateUsername() {
6667
config.put(AUTH_USERNAME_CONFIG, "username");
6768
ConfigValue configValue = configDef.validateAll(config).get(AUTH_USERNAME_CONFIG);
68-
assert (configValue.errorMessages().size() == 0);
69+
assertEquals(configValue.errorMessages().size(), 0);
6970
}
7071

7172
@Test
7273
public void validatePassword() {
7374
config.put(AUTH_PASSWORD_CONFIG, "password");
7475
ConfigValue configValue = configDef.validateAll(config).get(AUTH_PASSWORD_CONFIG);
75-
assert (configValue.errorMessages().size() == 0);
76+
assertEquals(configValue.errorMessages().size(), 0);
7677
}
7778

7879
}

src/test/java/com/simplesteph/kafka/model/IssueTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public void convertsToStruct(){
9494
// issue
9595
Issue issue = Issue.fromJson(issueJson);
9696
Struct struct = new GitHubSourceTask().buildRecordValue(issue);
97-
assert struct.get(GitHubSchemas.CREATED_AT_FIELD).getClass() == Date.class;
97+
assertEquals(struct.get(GitHubSchemas.CREATED_AT_FIELD).getClass(), Date.class);
9898
}
9999

100100
}

0 commit comments

Comments
 (0)