Skip to content

Commit 89db61c

Browse files
heysamtexasclaude
andcommitted
fix: make release workflow depend on test workflow (DRY principle)
- Add test job in release.yml that calls test.yml workflow - Make release job depend on test job with 'needs: test' - Remove redundant test step from release workflow - Fix test.yml to override Docker entrypoint and use uv run manage.py test - This follows DRY principle and ensures tests always run before releases 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent f81fd5b commit 89db61c

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/workflows/release.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,12 @@ permissions:
1818
id-token: write
1919

2020
jobs:
21+
test:
22+
uses: ./.github/workflows/test.yml
23+
2124
release:
2225
runs-on: ubuntu-latest
26+
needs: test
2327
steps:
2428
- name: Checkout repository
2529
uses: actions/checkout@v4
@@ -46,9 +50,6 @@ jobs:
4650
- name: Run formatting check
4751
run: uv run ruff format --check .
4852

49-
- name: Run tests
50-
run: uv run src/manage.py test
51-
5253
- name: Configure Git
5354
run: |
5455
git config user.name "github-actions[bot]"

.github/workflows/test.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,6 @@ jobs:
3434
-e AWS_S3_USE_SSL=false \
3535
-e EMAIL_URL=smtp://localhost:1025 \
3636
-e DEFAULT_FROM_EMAIL=test@localhost \
37+
--entrypoint "" \
3738
dri-test \
38-
python manage.py test
39+
uv run manage.py test

0 commit comments

Comments
 (0)