fix: resolve as js path instead of ts

Author: simonhaenisch

index.ts

@@ -1,7 +1,11 @@
+import { join } from 'path';
 import { CompilerOptions, findConfigFile, nodeModuleNameResolver, sys } from 'typescript';
 
-export const resolveTypescriptPaths = (options: Options = {}) => {
-	const compilerOptions = getCompilerOptions(options.tsConfigPath);
+export const resolveTypescriptPaths = ({
+	tsConfigPath = findConfigFile('./', sys.fileExists),
+	absolute = true,
+}: Options = {}) => {
+	const { compilerOptions, outDir } = getTsConfig(tsConfigPath);
 
 	return {
 		name: 'resolve-typescript-paths',
@@ -30,31 +34,45 @@ export const resolveTypescriptPaths = (options: Options = {}) => {
 				return null;
 			}
 
-			return resolvedFileName;
+			const jsFileName = join(outDir, resolvedFileName.replace(/\.tsx?$/i, '.js'));
+
+			return absolute ? sys.resolvePath(jsFileName) : jsFileName;
 		},
 	};
 };
 
-const getCompilerOptions = (configPath = findConfigFile('./', sys.fileExists)): CompilerOptions => {
+const getTsConfig = (configPath?: string): TsConfig => {
+	const defaults: TsConfig = { compilerOptions: {}, outDir: '.' };
+
 	if (!configPath) {
-		return {};
+		return defaults;
 	}
 
 	const configJson = sys.readFile(configPath);
 
 	if (!configJson) {
-		return {};
+		return defaults;
 	}
 
-	const config: { compilerOptions?: CompilerOptions } = JSON.parse(configJson);
-
-	if (!config || !config.compilerOptions) {
-		return {};
-	}
+	const config: Partial<TsConfig> = JSON.parse(configJson);
 
-	return config.compilerOptions;
+	return { ...defaults, ...config };
 };
 
 export interface Options {
+	/**
+	 * Custom path to your `tsconfig.json`. Use this if the plugin can't seem to
+	 * find the correct one by itself.
+	 */
 	tsConfigPath?: string;
+
+	/**
+	 * Whether to resolve to absolute paths or not; defaults to `true`.
+	 */
+	absolute?: boolean;
+}
+
+interface TsConfig {
+	compilerOptions: CompilerOptions;
+	outDir: string;
 }

package.json

@@ -22,6 +22,7 @@
   },
   "homepage": "https://github.com/simonhaenisch/rollup-plugin-typescript-paths#readme",
   "devDependencies": {
+    "@types/node": "12.0.3",
     "typescript": "^3.4.5"
   },
   "peerDependencies": {

readme.md

@@ -2,7 +2,7 @@
 
 [![Build Status](https://img.shields.io/endpoint.svg?url=https%3A%2F%2Factions-badge.atrox.dev%2Fsimonhaenisch%2Frollup-plugin-typescript-paths%2Fbadge&style=flat)](https://actions-badge.atrox.dev/simonhaenisch/rollup-plugin-typescript-paths/goto)
 
-Rollup Plugin to automatically resolve path aliases set in the `compilerOptions` section of `tsconfig.json`.
+Rollup Plugin to automatically resolve path aliases set in the `compilerOptions` section of `tsconfig.json`. It assumes that your Typescript code has already been transpiled before being rolled up (if that's not the case, you should probably use [rollup-plugin-typescript](https://github.com/rollup/rollup-plugin-typescript)).
 
 For example, if you have 
 
@@ -52,7 +52,8 @@ export default {
 
 ## Options
 
-* **`tsConfigPath`:** If the plugin has trouble finding your `tsconfig.json`, you can pass the path to it via this option.
+* **`tsConfigPath`:** Custom path to your `tsconfig.json`. Use this if the plugin can't seem to find the correct one by itself.
+* **`absolute`:** Whether to resolve to absolute paths or not; defaults to `true`.
 
 ## License
 

test/index.js

@@ -1,17 +1,17 @@
 #!/usr/bin/env node
 
 const { strictEqual } = require('assert');
-const { resolve } = require('path');
+const { resolve, join } = require('path');
 const { resolveTypescriptPaths } = require('../dist');
 
 const plugin = resolveTypescriptPaths({ tsConfigPath: resolve(__dirname, 'tsconfig.json') });
 
 try {
 	strictEqual(plugin.resolveId('@asdf', ''), null);
 	strictEqual(plugin.resolveId('\0@foobar', ''), null);
-	strictEqual(plugin.resolveId('@foobar', ''), 'test/foo/bar.ts');
-	strictEqual(plugin.resolveId('@bar/foo', ''), 'test/bar/foo.ts');
-	strictEqual(plugin.resolveId('@js', ''), 'test/js/index.js');
+	strictEqual(plugin.resolveId('@foobar', ''), join(__dirname, 'foo', 'bar.js'));
+	strictEqual(plugin.resolveId('@bar/foo', ''), join(__dirname, 'bar', 'foo.js'));
+	strictEqual(plugin.resolveId('@js', ''), join(__dirname, 'js', 'index.js'));
 
 	console.log('PASSED');
 } catch (error) {