test(request): add tests for Put- and TransactGetSingleTableRequest

Author: mumenthalers

src/dynamo/request/put/put.request.spec.ts

@@ -6,9 +6,13 @@ import { PutRequest } from './put.request'
 
 describe('put request', () => {
   describe('params', () => {
-    const request = new PutRequest(<any>null, SimpleWithPartitionKeyModel, {
-      id: 'myId',
-      age: 45,
+    let request: PutRequest<SimpleWithPartitionKeyModel>
+
+    beforeEach(() => {
+      request = new PutRequest(<any>null, SimpleWithPartitionKeyModel, {
+        id: 'myId',
+        age: 45,
+      })
     })
 
     it('constructor', () => {
@@ -28,6 +32,16 @@ describe('put request', () => {
       expect(params.ExpressionAttributeValues).toBeUndefined()
     })
 
+    it('ifNotExists with false  does add the predicate', () => {
+      // but it also does not remove it. it actually does nothing with false but returning the request instance
+      request.ifNotExists(false)
+
+      const params: DynamoDB.PutItemInput = request.params
+      expect(params.ConditionExpression).toBeUndefined()
+      expect(params.ExpressionAttributeNames).toBeUndefined()
+      expect(params.ExpressionAttributeValues).toBeUndefined()
+    })
+
     it('returnValues', () => {
       const req = request.returnValues('ALL_OLD')
       expect(req.params.ReturnValues).toEqual('ALL_OLD')

src/dynamo/request/put/put.request.ts

@@ -30,6 +30,7 @@ export class PutRequest<T> extends WriteRequest<T, DynamoDB.PutItemInput, Dynamo
 
   /**
    * Adds a condition expression to the request, which makes sure the item will only be saved if the id does not exist
+   * @param predicate if false is provided nothing happens (it does NOT remove the condition)
    */
   ifNotExists(predicate: boolean = true): PutRequest<T> {
     if (predicate) {

src/dynamo/request/transactgetsingletable/transact-get-single-table.request.spec.ts

@@ -1,3 +1,4 @@
+// tslint:disable:no-non-null-assertion
 import * as DynamoDB from 'aws-sdk/clients/dynamodb'
 import { SimpleWithPartitionKeyModel } from '../../../../test/models'
 import { metadataForModel } from '../../../decorator/metadata/metadata-for-model.function'
@@ -49,6 +50,10 @@ describe('TransactGetSingleTableRequest', () => {
       })
     })
 
+    it('execNoMap should return the raw value', async () => {
+      expect(await req.execNoMap()).toEqual(response)
+    })
+
     it('execFullResponse should map items and potentially return consumed capacity', async () => {
       const resp = await req.execFullResponse()
       expect(resp).toBeDefined()
@@ -61,4 +66,25 @@ describe('TransactGetSingleTableRequest', () => {
       })
     })
   })
+
+  describe('with empty response', () => {
+    const response: DynamoDB.TransactGetItemsOutput = {}
+    const transactGetItemsSpy = jasmine.createSpy().and.returnValue(Promise.resolve(response))
+    beforeEach(() => {
+      const dynamoDBWrapperMock: DynamoDbWrapper = <any>{ transactGetItems: transactGetItemsSpy }
+      req = new TransactGetSingleTableRequest(dynamoDBWrapperMock, SimpleWithPartitionKeyModel, [])
+    })
+    it('exec returns empty array', async () => {
+      expect(await req.exec()).toEqual([])
+    })
+    it('execNoMap returns original response (empty object)', async () => {
+      expect(await req.execNoMap()).toEqual({})
+    })
+    it('execFullResponse returns the response with empty items array', async () => {
+      expect(await req.execFullResponse()).toEqual({
+        ConsumedCapacity: undefined,
+        Items: [],
+      })
+    })
+  })
 })