Fix ch4, ch5, ch7

Author: Shehab Abdel-Salam

chapters/chapter04_control_flow/tests/test_ch04.py

@@ -60,15 +60,20 @@ def test_e20():
 
 
 def test_e21():
-    assert sum_numbers(0, 2) == 1
-    assert sum_numbers(1, 10) == 45
-    assert sum_numbers(1, 100) == 4950
+    assert sum_numbers(0, 0) == 0
+    assert sum_numbers(0, 1) == 1
+    assert sum_numbers(0, 2) == 3
+    assert sum_numbers(10, 15) == 75
+    assert sum_numbers(1, 10) == 55
+    assert sum_numbers(1, 100) == 5050
 
 
 def test_e22():
-    assert sum_even_numbers(0, 2) == 0
-    assert sum_even_numbers(1, 10) == 20
-    assert sum_even_numbers(1, 100) == 2450
+    assert sum_even_numbers(1, 5) == 6
+    assert sum_even_numbers(1, 10) == 30
+    assert sum_even_numbers(1, 20) == 110
+    assert sum_even_numbers(1, 30) == 240
+    assert sum_even_numbers(1, 40) == 420
 
 
 def test_e23():
@@ -91,6 +96,7 @@ def test_e25():
 
 
 def test_e26():
+    assert find_first_divisible_by_5([]) is None
     assert find_first_divisible_by_5([1, 2, 3, 4, 5]) == 5
     assert find_first_divisible_by_5([5, 10, 15, 20, 25]) == 5
     assert find_first_divisible_by_5([6, 7, 8, 9, 10]) == 10
@@ -111,7 +117,7 @@ def test_e28():
 
 
 def test_e29():
-    assert gpa_calculator([]) == 0
+    assert gpa_calculator([1]) == 1.0
     assert gpa_calculator([4, 3, 2]) == 3.0
     assert gpa_calculator([4, 3, 2, 1]) == 2.5
     assert gpa_calculator([4, 4, 4, 4]) == 4.0

chapters/chapter05_functions/tests/test_ch05.py

@@ -29,12 +29,14 @@ def test_e32():
 
 
 def test_e33():
-    assert fibonacci(1) == 0
+    assert fibonacci(1) == 1
     assert fibonacci(2) == 1
     assert fibonacci(3) == 2
     assert fibonacci(4) == 3
+    assert fibonacci(5) == 5
+    assert fibonacci(6) == 8
     assert fibonacci(10) == 55
-    assert fibonacci(20) == 4181
+    assert fibonacci(20) == 6765
 
 
 def test_e34():
@@ -47,17 +49,21 @@ def fifteen_percent(x: int):
     def five_dollar(x: int):
         return x - 5
 
-    assert apply_vouchers(ten_percent, total=100) == 90
-    assert apply_vouchers(fifteen_percent, total=100) == 85
-    assert apply_vouchers(five_dollar, total=100) == 95
-    assert apply_vouchers(ten_percent, fifteen_percent, total=100) == 76.5
-    assert apply_vouchers(ten_percent, fifteen_percent, five_dollar, total=100) == 71.5
+    assert apply_vouchers([ten_percent], total=100) == 90
+    assert apply_vouchers([fifteen_percent], total=100) == 85
+    assert apply_vouchers([five_dollar], total=100) == 95
+    assert apply_vouchers([ten_percent, fifteen_percent], total=100) == 76.5
+    assert (
+        apply_vouchers([ten_percent, fifteen_percent, five_dollar], total=100) == 71.5
+    )
 
 
 def test_e35():
-    assert find_max([1, 2, 3, 4, 5]) == 5
-    assert find_max([1, 2, 3, 4, 5, 6, 7, 8, 9, 10]) == 10
-    assert find_max([1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 0]) == 10
+    assert find_max(1) == 1
+    assert find_max(-1, -10, 8, 5) == 8
+    assert find_max(1, 2, 3) == 3
+    assert find_max(10, 20, 30) == 30
+    assert find_max(100, 200, 300) == 300
 
 
 def test_e36():

chapters/chapter07_strings/tests/test_ch07.py

@@ -13,7 +13,7 @@ def test_e50():
     assert get_substring("Hello, World!", 0, 5) == "Hello"
     assert get_substring("Hello, World!", 7, 12) == "World"
     assert get_substring("Python is fun!", 7, 9) == "is"
-    assert get_substring("Python is fun!", 0, 5) == "Python"
+    assert get_substring("Python is fun!", 0, 6) == "Python"
 
 
 def test_e51():
@@ -26,7 +26,7 @@ def test_e51():
 
 def test_e52():
     assert reverse_each_word("") == ""
-    assert reverse_each_word("HelloWorld") == "HelloWorld"
+    assert reverse_each_word("Hi there from Python") == "iH ereht morf nohtyP"
     assert reverse_each_word("Hello World") == "olleH dlroW"
     assert reverse_each_word("I want to reverse this") == "I tnaw ot esrever siht"
 
@@ -115,5 +115,5 @@ def test_e57():
     assert compress_string("abcd") == "abcd"
     assert compress_string("aaabbbbbcc") == "a3b5c2"
     assert compress_string("aabbbcc") == "a2b3c2"
-    assert compress_string("aaaaaabbbc") == "a6b2c"
+    assert compress_string("aaaaaabbbc") == "a6b3c"
     assert compress_string("aadddcccbb") == "a2d3c3b2"