CLOUDSTACK-8896: when the volume migrated to another pool the capacity calculations are fixed to take into account disk usage shifting from one pool to another

Signed-off-by: Abhinandan Prateek <aprateek@apache.org>

Author: Abhinandan Prateek

server/src/com/cloud/storage/StorageManagerImpl.java

@@ -1717,7 +1717,9 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool,
         if (!checkUsagedSpace(pool)) {
             return false;
         }
-
+        if (s_logger.isDebugEnabled()) {
+            s_logger.debug("Destination pool id: " + pool.getId());
+        }
         // allocated space includes templates
         StoragePoolVO poolVO = _storagePoolDao.findById(pool.getId());
         long allocatedSizeWithTemplate = _capacityMgr.getAllocatedPoolCapacity(poolVO, null);
@@ -1747,7 +1749,10 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool,
                 }
             }
 
-            if (volumeVO.getState() != Volume.State.Ready) {
+            if (s_logger.isDebugEnabled()) {
+                s_logger.debug("pool id for the volume with id: " + volumeVO.getId() + " is: " + volumeVO.getPoolId());
+            }
+            if (volumeVO.getState() != Volume.State.Ready || volumeVO.getPoolId() != pool.getId()) {
                 totalAskingSize += getDataObjectSizeIncludingHypervisorSnapshotReserve(volumeVO, pool);
 
                 if (ScopeType.ZONE.equals(poolVO.getScope()) && volumeVO.getTemplateId() != null) {