shapeblue10: live storage and VM migration (#11)

shapeblue10 (A1): qcow2 vs db discrepancy resulting in full clone becoming linked
shapeblue10 (A2): iso attached VM migration regression
shapeblue10 (B): create stub based full clone migration without needing snapshot

Author: nvazquez

api/src/com/cloud/storage/MigrationOptions.java

@@ -28,7 +28,6 @@ public class MigrationOptions implements Serializable {
     private String srcBackingFilePath;
     private String backingFile;
     private boolean copySrcTemplate;
-    private String snapshotName;
     private String srcVolumeUuid;
     private int timeout;
 
@@ -49,11 +48,10 @@ public MigrationOptions(String srcPoolUuid, Storage.StoragePoolType srcPoolType,
         this.backingFile = backingFile;
     }
 
-    public MigrationOptions(String srcPoolUuid, Storage.StoragePoolType srcPoolType, String snapshotName, String srcVolumeUuid) {
+    public MigrationOptions(String srcPoolUuid, Storage.StoragePoolType srcPoolType, String srcVolumeUuid) {
         this.srcPoolUuid = srcPoolUuid;
         this.srcPoolType = srcPoolType;
         this.type = Type.FullClone;
-        this.snapshotName = snapshotName;
         this.srcVolumeUuid = srcVolumeUuid;
     }
 
@@ -73,10 +71,6 @@ public boolean isCopySrcTemplate() {
         return copySrcTemplate;
     }
 
-    public String getSnapshotName() {
-        return snapshotName;
-    }
-
     public String getSrcVolumeUuid() {
         return srcVolumeUuid;
     }

core/src/com/cloud/agent/api/storage/ListVolumeBackingInformationAnswer.java

@@ -0,0 +1,36 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.api.storage;
+
+import com.cloud.agent.api.Answer;
+
+public class ListVolumeBackingInformationAnswer extends Answer {
+
+    private String backingFile;
+
+    public ListVolumeBackingInformationAnswer(String backingFile) {
+        super();
+        this.backingFile = backingFile;
+    }
+
+    public String getBackingFile() {
+        return backingFile;
+    }
+}

core/src/com/cloud/agent/api/storage/ListVolumeBackingInformationCommand.java

@@ -0,0 +1,59 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.api.storage;
+
+import com.cloud.storage.Storage.StoragePoolType;
+import org.apache.cloudstack.storage.command.StorageSubSystemCommand;
+
+public class ListVolumeBackingInformationCommand extends StorageSubSystemCommand {
+
+    private String volumePath;
+    private String poolUuid;
+    private StoragePoolType poolType;
+    private boolean inSeq;
+
+    public ListVolumeBackingInformationCommand(final String volumePath, final String poolUuid, final StoragePoolType poolType) {
+        this.volumePath = volumePath;
+        this.poolUuid = poolUuid;
+        this.poolType = poolType;
+    }
+
+    public String getVolumePath() {
+        return volumePath;
+    }
+
+    public String getPoolUuid() {
+        return poolUuid;
+    }
+
+    public StoragePoolType getPoolType() {
+        return poolType;
+    }
+
+    @Override
+    public void setExecuteInSequence(boolean inSeq) {
+        this.inSeq = inSeq;
+    }
+
+    @Override
+    public boolean executeInSequence() {
+        return inSeq;
+    }
+}

core/src/com/cloud/storage/resource/StorageProcessor.java

@@ -19,6 +19,7 @@
 
 package com.cloud.storage.resource;
 
+import com.cloud.agent.api.storage.ListVolumeBackingInformationCommand;
 import org.apache.cloudstack.storage.command.AttachCommand;
 import org.apache.cloudstack.storage.command.CopyCommand;
 import org.apache.cloudstack.storage.command.CreateObjectCommand;
@@ -71,4 +72,6 @@ public interface StorageProcessor {
     public Answer snapshotAndCopy(SnapshotAndCopyCommand cmd);
 
     public Answer resignature(ResignatureCommand cmd);
+
+    Answer listVolumeBackingInformation(ListVolumeBackingInformationCommand cmd);
 }

core/src/com/cloud/storage/resource/StorageSubsystemCommandHandlerBase.java

@@ -19,6 +19,7 @@
 
 package com.cloud.storage.resource;
 
+import com.cloud.agent.api.storage.ListVolumeBackingInformationCommand;
 import org.apache.log4j.Logger;
 
 import org.apache.cloudstack.storage.command.AttachCommand;
@@ -67,6 +68,8 @@ public Answer handleStorageCommands(StorageSubSystemCommand command) {
             return processor.snapshotAndCopy((SnapshotAndCopyCommand)command);
         } else if (command instanceof ResignatureCommand) {
             return processor.resignature((ResignatureCommand)command);
+        } else if (command instanceof ListVolumeBackingInformationCommand) {
+            return processor.listVolumeBackingInformation((ListVolumeBackingInformationCommand) command);
         }
 
         return new Answer((Command)command, false, "not implemented yet");

engine/components-api/src/com/cloud/storage/StorageManager.java

@@ -53,7 +53,7 @@ public interface StorageManager extends StorageService {
     ConfigKey<Integer> KvmStorageOnlineMigrationWait = new ConfigKey<>(Integer.class,
             "kvm.storage.online.migration.wait",
             "Storage",
-            "10800",
+            "86400",
             "Timeout in seconds for online (live) storage migration to complete on KVM (migrateVirtualMachineWithVolume)",
             true,
             ConfigKey.Scope.Global,