Skip to content

Commit 236cfa2

Browse files
author
Abhinandan Prateek
committed
CLOUDSTACK-9569: override default setting with values set in agent.properties
1 parent 23fdd7b commit 236cfa2

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

core/src/com/cloud/agent/resource/virtualnetwork/VRScripts.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public class VRScripts {
4242
public static final String LOAD_BALANCER_CONFIG = "load_balancer.json";
4343

4444
public final static String CONFIG_CACHE_LOCATION = "/var/cache/cloud/";
45-
public final static Duration VR_SCRIPT_EXEC_TIMEOUT = Duration.standardMinutes(10);
45+
public final static Duration VR_SCRIPT_EXEC_TIMEOUT = Duration.standardMinutes(2);
4646
public final static Duration CONNECTION_TIMEOUT = Duration.standardMinutes(1);
4747

4848
// New scripts for use with chef

core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,9 @@ public boolean configure(final String name, final Map<String, Object> params) th
273273

274274
value = (String)params.get("router.aggregation.command.each.timeout");
275275
_eachTimeout = Duration.standardSeconds(NumbersUtil.parseInt(value, 10));
276+
if (s_logger.isDebugEnabled()){
277+
s_logger.debug("The router.aggregation.command.each.timeout in seconds is set to " + _eachTimeout.getStandardSeconds());
278+
}
276279

277280
if (_vrDeployer == null) {
278281
throw new ConfigurationException("Unable to find the resource for VirtualRouterDeployer!");
@@ -376,8 +379,8 @@ private Answer execute(AggregationControlCommand cmd) {
376379
ScriptConfigItem scriptConfigItem = new ScriptConfigItem(VRScripts.VR_CFG, "-c " + VRScripts.CONFIG_CACHE_LOCATION + cfgFileName);
377380
// 120s is the minimal timeout
378381
Duration timeout = _eachTimeout.withDurationAdded(_eachTimeout.getStandardSeconds(), answerCounts);
379-
if (timeout.isShorterThan(VRScripts.VR_SCRIPT_EXEC_TIMEOUT)) {
380-
timeout = VRScripts.VR_SCRIPT_EXEC_TIMEOUT;
382+
if (s_logger.isDebugEnabled()){
383+
s_logger.debug("Aggregate action timeout in seconds is " + timeout.getStandardSeconds());
381384
}
382385

383386
ExecutionResult result = applyConfigToVR(cmd.getRouterAccessIp(), fileConfigItem);

0 commit comments

Comments
 (0)