Demo of Github Action Workflow Changes (#644)

* stop triggering review app deployment on opening of pr

* remove push event references since redundant with PR synchronization

* remove twitter reference

* don't deploy on pull request trigger

* update help

* make sure to checkout right ref before setup

Author: Judahmeek

.github/workflows/deploy-to-control-plane-review-app.yml

@@ -5,7 +5,7 @@ run-name: Deploy PR Review App - PR #${{ github.event.pull_request.number || git
 # Controls when the workflow will run
 on:
   pull_request:
-    types: [opened, synchronize, reopened]
+    types: [synchronize, reopened]
   issue_comment:
     types: [created]
   workflow_dispatch:
@@ -26,7 +26,6 @@ jobs:
   deploy:
     if: |
       (github.event_name == 'pull_request') ||
-      (github.event_name == 'push') ||
       (github.event_name == 'workflow_dispatch') ||
       (github.event_name == 'issue_comment' && 
        github.event.issue.pull_request && 
@@ -41,34 +40,22 @@ jobs:
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          # For push events, try to find associated PR first
-          if [[ "${{ github.event_name }}" == "push" ]]; then
-            PR_DATA=$(gh pr list --head "${{ github.ref_name }}" --json number,headRefName,headRefOid --jq '.[0]')
-            if [[ -n "$PR_DATA" ]]; then
-              PR_NUMBER=$(echo "$PR_DATA" | jq -r .number)
-            else
-              echo "No PR found for branch ${{ github.ref_name }}, skipping deployment"
-              echo "DO_DEPLOY=false" >> $GITHUB_ENV
-              exit 0
-            fi
-          else
-            # Get PR number based on event type
-            case "${{ github.event_name }}" in
-              "workflow_dispatch")
-                PR_NUMBER="${{ github.event.inputs.pr_number }}"
-                ;;
-              "issue_comment")
-                PR_NUMBER="${{ github.event.issue.number }}"
-                ;;
-              "pull_request")
-                PR_NUMBER="${{ github.event.pull_request.number }}"
-                ;;
-              *)
-                echo "Error: Unsupported event type ${{ github.event_name }}"
-                exit 1
-                ;;
-            esac
-          fi
+          # Get PR number based on event type
+          case "${{ github.event_name }}" in
+            "workflow_dispatch")
+              PR_NUMBER="${{ github.event.inputs.pr_number }}"
+              ;;
+            "issue_comment")
+              PR_NUMBER="${{ github.event.issue.number }}"
+              ;;
+            "pull_request")
+              PR_NUMBER="${{ github.event.pull_request.number }}"
+              ;;
+            *)
+              echo "Error: Unsupported event type ${{ github.event_name }}"
+              exit 1
+              ;;
+          esac
 
           if [[ -z "$PR_NUMBER" ]]; then
             echo "Error: Could not determine PR number"
@@ -125,6 +112,9 @@ jobs:
 
           # Check if app exists and save state
           if ! cpflow exists -a ${{ env.APP_NAME }}; then
+            if [[ "${{ github.event_name }}" == "pull_request" ]]; then
+              exit 0
+            fi
             echo "APP_EXISTS=false" >> $GITHUB_ENV
           else
             echo "APP_EXISTS=true" >> $GITHUB_ENV

.github/workflows/help-command.yml

@@ -27,7 +27,7 @@ jobs:
             const sections = {
               commands: {
                 deploy: {
-                  title: '## `/deploy`',
+                  title: '## `/deploy-review-app`',
                   purpose: '**Purpose:** Deploy a review app for your pull request',
                   details: [
                     '**What it does:**',
@@ -43,7 +43,7 @@ jobs:
                   ]
                 },
                 destroy: {
-                  title: '## `/destroy`',
+                  title: '## `/delete-review-app`',
                   purpose: '**Purpose:** Remove the review app for your pull request',
                   details: [
                     '**What it does:**',
@@ -94,9 +94,9 @@ jobs:
               cleanup: {
                 title: '## Automatic Cleanup',
                 details: [
-                  'Review apps are automatically destroyed when:',
+                  'Review apps are automatically deleted when:',
                   '1. The pull request is closed',
-                  '2. The `/destroy` command is used',
+                  '2. The `/delete-review-app` command is used',
                   '3. A new deployment is requested (old one is cleaned up first)'
                 ]
               },

client/app/bundles/comments/components/Footer/Footer.jsx

@@ -14,7 +14,7 @@ export default class Footer extends BaseComponent {
           </a>
           <a href="https://x.com/railsonmaui" className="flex gap-4 items-center">
             <div className="w-16 h-16 bg-[url('../images/twitter_64.png')]" />
-            Rails On Maui on X (Twitter)
+            Rails On Maui on X
           </a>
         </div>
       </footer>