fix SmartFactoryWrapper to handle deleted factory files

Author: Grant Petersen-Speelman

lib/cypress_dev/smart_factory_wrapper.rb

@@ -29,19 +29,20 @@ def self.create_list(*args)
     end
 
     # @return [Array]
-    attr_accessor :files
     attr_accessor :factory
     attr_accessor :always_reload
 
     def initialize(files:, factory:, always_reload: false,
-                   factory_cleaner: FactoryCleaner, kernel: Kernel, file_system: File)
+                   factory_cleaner: FactoryCleaner, kernel: Kernel, file_system: File,
+                   dir_system: Dir)
       self.files = files
       self.factory = factory
       self.always_reload = always_reload
       @kernel = kernel
       @file_system = file_system
       @factory_cleaner = factory_cleaner
       @latest_mtime = nil
+      @dir_system = dir_system
     end
 
     def create(*args)
@@ -56,6 +57,17 @@ def create_list(*args)
 
     private
 
+    # @param [String,Array] arg
+    def files=(array)
+      array = [array] if array.is_a?(String)
+      @dir_array = array
+    end
+
+    # @return [Array<String>]
+    def files
+      Dir[*@dir_array]
+    end
+
     def logger
       CypressDev.configuration.logger
     end

lib/generators/cypress_dev/templates/spec/cypress/cypress_helper.rb

@@ -26,5 +26,5 @@
 CypressDev::SmartFactoryWrapper.configure(
     always_reload: !Rails.configuration.cache_classes,
     factory: factory,
-    files: Dir['./spec/factories/**/*.rb']
+    files: %w(spec/factories.rb ./spec/factories/**/*.rb)
 )

spec/cypress_dev/smart_factory_wrapper_spec.rb

@@ -14,12 +14,18 @@ def mtime(filename)
   let(:factory_cleaner) { class_double(CypressDev::SmartFactoryWrapper::FactoryCleaner, clean: true) }
   let(:kernel_double) { class_double(Kernel, load: true) }
   let(:file_double) { FileSystemDummy.new(mtime_hash) }
+  let(:dir_double) { class_double(Dir) }
+
+  before do
+    allow(Dir).to receive(:[]).with(*files) { mtime_hash.keys }
+  end
 
   subject do
     described_class.new(files: files,
                         factory: factory_double,
                         kernel: kernel_double,
                         file_system: file_double,
+                        dir_system: dir_double,
                         factory_cleaner: factory_cleaner)
   end
 
@@ -52,7 +58,7 @@ def mtime(filename)
     expect(kernel_double).to have_received(:load).with('file2.rb').once
   end
 
-  it 'will reload the files if a has changed' do
+  it 'will reload the files if any have changed' do
     subject.create(:user)
     expect(kernel_double).to have_received(:load).with('file1.rb').once
     expect(kernel_double).to have_received(:load).with('file2.rb').once
@@ -63,6 +69,18 @@ def mtime(filename)
     expect(kernel_double).to have_received(:load).with('file2.rb').twice
   end
 
+  it 'will reload only the files that exist' do
+    subject.always_reload = true
+    subject.create(:user)
+    expect(kernel_double).to have_received(:load).with('file1.rb').once
+    expect(kernel_double).to have_received(:load).with('file2.rb').once
+
+    mtime_hash.delete('file1.rb')
+    subject.create_list(:user)
+    expect(kernel_double).to have_received(:load).with('file1.rb').once
+    expect(kernel_double).to have_received(:load).with('file2.rb').twice
+  end
+
   it 'will reset factory if a has changed' do
     subject.create(:user)
     expect(factory_cleaner).to have_received(:clean).with(factory_double)
@@ -80,4 +98,18 @@ def mtime(filename)
     expect(kernel_double).to have_received(:load).with('file1.rb').twice
     expect(kernel_double).to have_received(:load).with('file2.rb').twice
   end
+
+  context 'files is a string' do
+    let(:files) { 'file*.rb' }
+
+    before do
+      allow(Dir).to receive(:[]).with('file*.rb') { mtime_hash.keys }
+    end
+
+    it 'loads all the files on first create it' do
+      subject.create(:user)
+      expect(kernel_double).to have_received(:load).with('file1.rb')
+      expect(kernel_double).to have_received(:load).with('file2.rb')
+    end
+  end
 end