Always use raise to signal exceptions

Author: sferik

Gemfile

@@ -14,7 +14,7 @@ end
 group :test do
   gem 'coveralls'
   gem 'rspec', '>= 3'
-  gem 'rubocop', '>= 0.28'
+  gem 'rubocop', '>= 0.37'
   gem 'simplecov', '>= 0.9'
   gem 'timecop'
   gem 'webmock', '>= 1.10.1'

lib/t/rcfile.rb

@@ -20,7 +20,7 @@ def find(username)
       if possibilities.size == 1
         possibilities.first
       else
-        fail(ArgumentError.new("Username #{username} is #{possibilities.size < 1 ? 'not found.' : 'ambiguous, matching ' + possibilities.join(', ')}"))
+        raise(ArgumentError.new("Username #{username} is #{possibilities.size < 1 ? 'not found.' : 'ambiguous, matching ' + possibilities.join(', ')}"))
       end
     end
 

tasks/bash.rake

@@ -12,7 +12,7 @@ namespace :completion do
     if git_status[/M #{output_path}/]
       cmd = "git add #{output_path} && git commit -m 'Updating Bash completion'"
       result = system cmd
-      fail('Could not commit changes') unless result
+      raise('Could not commit changes') unless result
     end
   end
 end

tasks/zsh.rake

@@ -12,7 +12,7 @@ namespace :completion do
     if git_status[/M #{output_path}/]
       cmd = "git add #{output_path} && git commit -m 'Updating Zsh completion'"
       result = system cmd
-      fail('Could not commit changes') unless result
+      raise('Could not commit changes') unless result
     end
   end
 end