Skip to content

Commit ffae05c

Browse files
authored
ReadVersion0 method was too verbose (#882)
it can be compacted Signed-off-by: fjtirado <ftirados@redhat.com>
1 parent 8d07e14 commit ffae05c

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

impl/persistence/bigmap/src/main/java/io/serverlessworkflow/impl/persistence/bigmap/BytesMapInstanceReader.java

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import io.serverlessworkflow.impl.persistence.PersistenceTaskInfo;
2424
import io.serverlessworkflow.impl.persistence.RetriedTaskInfo;
2525
import java.io.ByteArrayInputStream;
26-
import java.time.Instant;
2726

2827
public class BytesMapInstanceReader extends BigMapInstanceReader<byte[], byte[], byte[]> {
2928

@@ -61,17 +60,12 @@ private PersistenceTaskInfo readVersion1(WorkflowInputBuffer buffer) {
6160
}
6261

6362
private PersistenceTaskInfo readVersion0(WorkflowInputBuffer buffer) {
64-
Instant date = buffer.readInstant();
65-
WorkflowModel model = (WorkflowModel) buffer.readObject();
66-
WorkflowModel context = (WorkflowModel) buffer.readObject();
67-
Boolean isEndNode = null;
68-
String nextPosition = null;
69-
isEndNode = buffer.readBoolean();
70-
boolean hasNext = buffer.readBoolean();
71-
if (hasNext) {
72-
nextPosition = buffer.readString();
73-
}
74-
return new CompletedTaskInfo(date, model, context, isEndNode, nextPosition);
63+
return new CompletedTaskInfo(
64+
buffer.readInstant(),
65+
(WorkflowModel) buffer.readObject(),
66+
(WorkflowModel) buffer.readObject(),
67+
buffer.readBoolean(),
68+
buffer.readBoolean() ? buffer.readString() : null);
7569
}
7670

7771
@Override

0 commit comments

Comments
 (0)