Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Commit c04effa

Browse files
committed
PR comments:
- Drop .eslintrc.js in favor of package.json - Remove aspirational comments. - Correct README. - Don't increase usage of lodash.
1 parent 5986055 commit c04effa

File tree

5 files changed

+11
-29
lines changed

5 files changed

+11
-29
lines changed

.eslintrc.js

Lines changed: 0 additions & 18 deletions
This file was deleted.

.github/workflows/test.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
name: Test
22

33
on: [push]
4-
# pull_request:
5-
# branches:
6-
# - master
7-
# push:
8-
# branches:
9-
# - master
104

115
jobs:
126
build:
@@ -15,8 +9,8 @@ jobs:
159
fail-fast: false
1610
matrix:
1711
os: [ubuntu-latest, windows-latest, macOS-latest]
18-
python-version: [3.6, 2.7] # 3.7
19-
node-version: [12] # 8, 10
12+
python-version: [3.6, 2.7]
13+
node-version: [12]
2014
steps:
2115
- uses: actions/checkout@v2
2216

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
[![npm](https://img.shields.io/npm/v/serverless-python-requirements.svg)](https://www.npmjs.com/package/serverless-python-requirements)
66
[![code style: prettier](https://img.shields.io/badge/code_style-prettier-ff69b4.svg)](https://github.com/prettier/prettier)
77

8-
A Serverless v5.x plugin to automatically bundle dependencies from
8+
A Serverless v1.x plugin to automatically bundle dependencies from
99
`requirements.txt` and make them available in your `PYTHONPATH`.
1010

1111
## Requires Serverless >= v1.34

package.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,15 @@
7070
"eslintConfig": {
7171
"extends": "eslint:recommended",
7272
"env": {
73+
"commonjs": true,
7374
"node": true,
7475
"es6": true
76+
},
77+
"parserOptions": {
78+
"ecmaVersion": 2018
79+
},
80+
"rules": {
81+
"no-console": "off"
7582
}
7683
},
7784
"prettier": {

test.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ const {
1414
} = require('fs-extra');
1515
const { quote } = require('shell-quote');
1616
const { sep } = require('path');
17-
const { _ } = require('lodash');
1817

1918
const { getUserCachePath, sha256Path } = require('./lib/shared');
2019

@@ -159,7 +158,7 @@ const availablePythons = (() => {
159158
}
160159
}
161160
}
162-
if (_.isEmpty(mapping)) {
161+
if (!Object.entries(mapping).length) {
163162
throw new Error('No pythons found');
164163
}
165164
return mapping;

0 commit comments

Comments
 (0)