Add final param for web actions.

Fixes #132

Author: jthomas

compile/functions/index.js

@@ -105,15 +105,29 @@ class OpenWhiskCompileFunctions {
         .map(key => ({ key, value: functionObject.parameters[key] }));
 
       // optional action annotations 
-      const Annotations = Object.keys(functionObject.annotations || {})
-        .map(key => ({ key, value: functionObject.annotations[key] }));
+      const Annotations = this.constructAnnotations(functionObject.annotations);
 
       return this.compileFunctionAction(
         { FunctionName, NameSpace, Overwrite, Exec, Timeout, MemorySize, Parameters, Annotations }
       );
     });
   }
 
+  constructAnnotations (annotations) {
+    if (!annotations) return []
+
+    // finalise action parameters when exposing as external HTTP endpoint.
+    // mirrors behaviour from OpenWhisk CLI.
+    if (annotations['web-export']) {
+      annotations['final'] = true
+    }
+
+    const converted = Object.keys(annotations)
+      .map(key => ({ key, value: annotations[key] }));
+
+    return converted
+  }
+
   logCompiledFunction (name, fn) {
     const clone = JSON.parse(JSON.stringify(fn))
     if (clone.action.exec.code) {

compile/functions/tests/index.js

@@ -71,6 +71,35 @@ describe('OpenWhiskCompileFunctions', () => {
     });
   });
 
+  describe('#constructAnnotations()', () => {
+    it('should handle missing annotations', () => {
+      expect(openwhiskCompileFunctions.constructAnnotations())
+        .to.deep.equal([]);
+    })
+    it('should handle empty annotations', () => {
+      expect(openwhiskCompileFunctions.constructAnnotations({}))
+        .to.deep.equal([]);
+    })
+    it('should handle annotations present', () => {
+      expect(openwhiskCompileFunctions.constructAnnotations({
+        hello: 'world', foo: 'bar'
+      })).to.deep.equal([
+        { key: 'hello', value: 'world' },
+        { key: 'foo', value: 'bar' }
+      ]);
+    })
+    it('should add final annotations if web-export is present', () => {
+      expect(openwhiskCompileFunctions.constructAnnotations({
+        hello: 'world', foo: 'bar', "web-export": true
+      })).to.deep.equal([
+        { key: 'hello', value: 'world' },
+        { key: 'foo', value: 'bar' },
+        { key: 'web-export', value: true },
+        { key: 'final', value: true }
+      ]);
+    })
+  })
+
   describe('#calculateFunctionNameSpace()', () => {
     it('should return namespace from function object', () => {
       expect(openwhiskCompileFunctions