add test

Author: horike37

lib/deploy/events/apiGateway/deployment.test.js

@@ -0,0 +1,69 @@
+'use strict';
+
+const expect = require('chai').expect;
+const Serverless = require('serverless/lib/Serverless');
+const AwsProvider = require('serverless/lib/plugins/aws/provider/awsProvider');
+const ServerlessStepFunctions = require('./../../../index');
+
+describe('#compileDeployment()', () => {
+  let serverless;
+  let serverlessStepFunctions;
+
+  beforeEach(() => {
+    serverless = new Serverless();
+    serverless.setProvider('aws', new AwsProvider(serverless));
+    serverless.service.provider.compiledCloudFormationTemplate = {
+      Resources: {},
+      Outputs: {},
+    };
+    const options = {
+      stage: 'dev',
+      region: 'us-east-1',
+    };
+    serverlessStepFunctions = new ServerlessStepFunctions(serverless, options);
+    serverlessStepFunctions.apiGatewayRestApiLogicalId = 'ApiGatewayRestApi';
+    serverlessStepFunctions.apiGatewayMethodLogicalIds
+      = ['method-dependency1', 'method-dependency2'];
+  });
+
+  it('should create a deployment resource', () => serverlessStepFunctions
+    .compileDeployment().then(() => {
+      const apiGatewayDeploymentLogicalId = Object
+        .keys(serverlessStepFunctions.serverless.service.provider
+          .compiledCloudFormationTemplate.Resources)[0];
+
+      expect(
+        serverlessStepFunctions.serverless.service.provider.compiledCloudFormationTemplate
+          .Resources[apiGatewayDeploymentLogicalId]
+      ).to.deep.equal({
+        Type: 'AWS::ApiGateway::Deployment',
+        DependsOn: ['method-dependency1', 'method-dependency2'],
+        Properties: {
+          RestApiId: { Ref: serverlessStepFunctions.apiGatewayRestApiLogicalId },
+          StageName: 'dev',
+        },
+      });
+    })
+  );
+
+  it('should add service endpoint output', () =>
+    serverlessStepFunctions.compileDeployment().then(() => {
+      expect(
+        serverlessStepFunctions.serverless.service.provider.compiledCloudFormationTemplate
+          .Outputs.ServiceEndpoint
+      ).to.deep.equal({
+        Description: 'URL of the service endpoint',
+        Value: {
+          'Fn::Join': [
+            '',
+            [
+              'https://',
+              { Ref: serverlessStepFunctions.apiGatewayRestApiLogicalId },
+              '.execute-api.us-east-1.amazonaws.com/dev',
+            ],
+          ],
+        },
+      });
+    })
+  );
+});

lib/deploy/events/apiGateway/methods.js

@@ -23,10 +23,6 @@ module.exports = {
         },
       };
 
-      if (event.http.private) {
-        template.Properties.ApiKeyRequired = true;
-      }
-
       _.merge(template,
         this.getMethodIntegration(event.stateMachineName),
         this.getMethodResponses()

lib/deploy/events/apiGateway/methods.test.js

@@ -0,0 +1,48 @@
+'use strict';
+
+const expect = require('chai').expect;
+const Serverless = require('serverless/lib/Serverless');
+const AwsProvider = require('serverless/lib/plugins/aws/provider/awsProvider');
+const ServerlessStepFunctions = require('./../../../index');
+
+describe('#compileMethods()', () => {
+  let serverless;
+  let serverlessStepFunctions;
+
+  beforeEach(() => {
+    serverless = new Serverless();
+    serverless.setProvider('aws', new AwsProvider(serverless));
+    serverless.service.provider.compiledCloudFormationTemplate = {
+      Resources: {},
+    };
+
+    const options = {
+      stage: 'dev',
+      region: 'us-east-1',
+    };
+    serverlessStepFunctions = new ServerlessStepFunctions(serverless, options);
+    serverlessStepFunctions.apiGatewayResourceLogicalIds
+      = { 'foo/bar': 'apiGatewayResourceLogicalId' };
+    serverlessStepFunctions.apiGatewayResourceNames
+      = { 'foo/bar': 'apiGatewayResourceNames' };
+    serverlessStepFunctions.pluginhttpValidated = {
+      events: [
+        {
+          stateMachineName: 'first',
+          http: {
+            path: 'foo/bar',
+            method: 'post',
+          },
+        },
+      ],
+    };
+  });
+
+  it('should create a method resource', () => serverlessStepFunctions
+    .compileMethods().then(() => {
+      expect(serverlessStepFunctions.serverless.service.provider.compiledCloudFormationTemplate
+        .Resources)
+      .to.have.property('ApiGatewayMethodapiGatewayResourceNamesPost');
+    })
+  );
+});

lib/deploy/events/apiGateway/validate.js

@@ -5,7 +5,6 @@ const _ = require('lodash');
 module.exports = {
   httpValidate() {
     const events = [];
-    const corsPreflight = {};
 
     _.forEach(this.getAllStateMachines(), (stateMachineName) => {
       const stateMachineObj = this.getStateMachine(stateMachineName);
@@ -25,7 +24,6 @@ module.exports = {
 
     return {
       events,
-      corsPreflight,
     };
   },