Skip to content

Commit 76e083b

Browse files
committed
update iam test
1 parent 3316ddc commit 76e083b

File tree

2 files changed

+58
-9
lines changed

2 files changed

+58
-9
lines changed

lib/iam.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -157,12 +157,6 @@ module.exports = {
157157
});
158158

159159
return BbPromise.map(promises, (state) => this.deleteIamRole(state))
160-
.then(() => BbPromise.resolve())
161-
.catch((error) => {
162-
if (error.statusCode === 404) {
163-
return BbPromise.resolve();
164-
}
165-
return BbPromise.reject(error.message);
166-
});
160+
.then(() => BbPromise.resolve());
167161
},
168162
};

lib/iam.test.js

Lines changed: 57 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,13 +151,68 @@ describe('iam', () => {
151151
serverlessStepFunctions.provider.request.restore();
152152
})
153153
);
154+
155+
it('should deleteIamRole when 404 error', () => {
156+
serverlessStepFunctions.provider.request.restore();
157+
deleteIamRoleStub = sinon.stub(serverlessStepFunctions.provider, 'request')
158+
.returns(BbPromise.reject({ statusCode: 404 }));
159+
serverlessStepFunctions.deleteIamRole()
160+
.then(() => {
161+
expect(deleteIamRoleStub.callCount).to.be.equal(1);
162+
serverlessStepFunctions.provider.request.restore();
163+
})
164+
});
165+
166+
it('should other when other error', () => {
167+
serverlessStepFunctions.provider.request.restore();
168+
deleteIamRoleStub = sinon.stub(serverlessStepFunctions.provider, 'request')
169+
.returns(BbPromise.reject({ statusCode: 500 }));
170+
serverlessStepFunctions.deleteIamRole()
171+
.catch(() => {
172+
expect(deleteIamRoleStub.callCount).to.be.equal(1);
173+
serverlessStepFunctions.provider.request.restore();
174+
})
175+
});
154176
});
155177

156178
describe('#getIamRoles()', () => {
157-
// @todo
179+
let getIamRoleStub;
180+
beforeEach(() => {
181+
serverless.service.stepFunctions = {
182+
helloHello: 'value',
183+
hogeHoge: 'value',
184+
sssss: 'value',
185+
};
186+
getIamRoleStub = sinon
187+
.stub(serverlessStepFunctions, 'getIamRole').returns(BbPromise.resolve());
188+
});
189+
190+
it('should getIamRoles with correct params'
191+
, () => serverlessStepFunctions.getIamRoles()
192+
.then(() => {
193+
expect(getIamRoleStub.calledThrice).to.be.equal(true);
194+
serverlessStepFunctions.getIamRole.restore();
195+
})
196+
);
158197
});
159198

160199
describe('#deleteIamRoles()', () => {
161-
// @todo
200+
let deleteIamRoleStub;
201+
beforeEach(() => {
202+
serverless.service.stepFunctions = {
203+
helloHello: 'value',
204+
hogeHoge: 'value',
205+
};
206+
deleteIamRoleStub = sinon
207+
.stub(serverlessStepFunctions, 'deleteIamRole').returns(BbPromise.resolve());
208+
});
209+
210+
it('should deleteIamRoles with correct params'
211+
, () => serverlessStepFunctions.deleteIamRoles()
212+
.then(() => {
213+
expect(deleteIamRoleStub.calledTwice).to.be.equal(true);
214+
serverlessStepFunctions.deleteIamRole.restore();
215+
})
216+
);
162217
});
163218
});

0 commit comments

Comments
 (0)