Add limit

Author: sungam3r

src/Serilog.Extensions.Logging/Extensions/Logging/SerilogLogger.cs

@@ -13,8 +13,17 @@ namespace Serilog.Extensions.Logging;
 
 class SerilogLogger : FrameworkLogger
 {
-    internal static readonly ConcurrentDictionary<string, string> DestructureDictionary = new ConcurrentDictionary<string, string>();
-    internal static readonly ConcurrentDictionary<string, string> StringifyDictionary = new ConcurrentDictionary<string, string>();
+    internal static readonly ConcurrentDictionary<string, string> DestructureDictionary = new();
+    internal static readonly ConcurrentDictionary<string, string> StringifyDictionary = new();
+
+    internal static string GetKeyWithoutFirstSymbol(ConcurrentDictionary<string, string> source, string key)
+    {
+        if (source.TryGetValue(key, out var value))
+            return value;
+        if (source.Count < 1000)
+            return source.GetOrAdd(key, k => k.Substring(1));
+        return key.Substring(1);
+    }
 
     readonly SerilogLoggerProvider _provider;
     readonly ILogger _logger;
@@ -92,12 +101,12 @@ void Write<TState>(LogEventLevel level, EventId eventId, TState state, Exception
                 }
                 else if (property.Key.StartsWith("@"))
                 {
-                    if (logger.BindProperty(DestructureDictionary.GetOrAdd(property.Key, k => k.Substring(1)), property.Value, true, out var destructured))
+                    if (logger.BindProperty(GetKeyWithoutFirstSymbol(DestructureDictionary, property.Key), property.Value, true, out var destructured))
                         properties.Add(destructured);
                 }
                 else if (property.Key.StartsWith("$"))
                 {
-                    if (logger.BindProperty(StringifyDictionary.GetOrAdd(property.Key, k => k.Substring(1)), property.Value?.ToString(), true, out var stringified))
+                    if (logger.BindProperty(GetKeyWithoutFirstSymbol(StringifyDictionary, property.Key), property.Value?.ToString(), true, out var stringified))
                         properties.Add(stringified);
                 }
                 else

src/Serilog.Extensions.Logging/Extensions/Logging/SerilogLoggerScope.cs

@@ -59,12 +59,12 @@ void AddProperty(KeyValuePair<string, object> stateProperty)
 
             if (key.StartsWith("@"))
             {
-                key = SerilogLogger.DestructureDictionary.GetOrAdd(key, k => k.Substring(1));
+                key = SerilogLogger.GetKeyWithoutFirstSymbol(SerilogLogger.DestructureDictionary, key);
                 destructureObject = true;
             }
             else if (key.StartsWith("$"))
             {
-                key = SerilogLogger.StringifyDictionary.GetOrAdd(key, k => k.Substring(1));
+                key = SerilogLogger.GetKeyWithoutFirstSymbol(SerilogLogger.StringifyDictionary, key);
                 value = value?.ToString();
             }
 

test/Serilog.Extensions.Logging.Benchmarks/LogEventBenchmark.cs

@@ -1,4 +1,4 @@
-// Copyright 2019 Serilog Contributors
+// Copyright 2019 Serilog Contributors
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -18,14 +18,16 @@
 using Xunit;
 using IMelLogger = Microsoft.Extensions.Logging.ILogger;
 
+#pragma warning disable xUnit1013 // Public method should be marked as test
+
 namespace Serilog.Extensions.Logging.Benchmarks
 {
     [MemoryDiagnoser]
     public class LogEventBenchmark
     {
         private class Person
         {
-            public string Name { get; set; }
+            public string? Name { get; set; }
             public int Age { get; set; }
             public override string ToString() => "Fixed text";
         }
@@ -36,7 +38,7 @@ private class Person
         public LogEventBenchmark()
         {
             var underlyingLogger = new LoggerConfiguration().CreateLogger();
-            _melLogger = new SerilogLoggerProvider(underlyingLogger).CreateLogger(GetType().FullName);
+            _melLogger = new SerilogLoggerProvider(underlyingLogger).CreateLogger(GetType().FullName!);
             _bob = new Person { Name = "Bob", Age = 42 };
             _alice = new Person { Name = "Alice", Age = 42 };
         }