check-mysql-replication-status: improve rspec test

Author: Jan Kunzmann

test/check-mysql-replication-status_spec.rb

@@ -34,31 +34,32 @@
   let(:checker) { described_class.new }
   let(:exit_code) { nil }
 
+  # Mock result handlers
   before(:each) do
     def checker.ok(*_args)
-      exit 0
+      exit
     end
 
     def checker.warning(*_args)
-      exit 1
+      exit
     end
 
     def checker.critical(*_args)
-      exit 2
+      exit
     end
   end
 
   [
-    ['Yes', 'Yes', 0, 0, 'ok'],
-    ['No',  'Yes', nil, 2, 'critical'],
-    ['Yes', 'No', nil, 2, 'critical'],
-    ['No',  'No',  nil, 2, 'critical'],
-    ['Yes', 'Yes', 900, 0, 'ok'],
-    ['Yes', 'Yes', 901, 1, 'warning'],
-    ['Yes', 'Yes', 1800, 1, 'warning'],
-    ['Yes', 'Yes', 1801, 2, 'critical'],
+    ['Yes', 'Yes', 0, :ok],
+    ['No',  'Yes', nil, :critical],
+    ['Yes', 'No', nil, :critical],
+    ['No',  'No',  nil, :critical],
+    ['Yes', 'Yes', 900, :ok],
+    ['Yes', 'Yes', 901, :warning],
+    ['Yes', 'Yes', 1800, :warning],
+    ['Yes', 'Yes', 1801, :critical],
   ].each do |testdata|
-    it "returns #{testdata[4]} for default thresholds" do
+    it "returns #{testdata[3]} for default thresholds" do
       slave_status_row = {
         'Slave_IO_State' => '',
         'Slave_IO_Running' => testdata[0],
@@ -67,23 +68,22 @@ def checker.critical(*_args)
         'Last_SQL_Error' => '',
         'Seconds_Behind_Master' => testdata[2]
       }
+      allow(checker).to receive(:open_connection) # do nothing
+      allow(checker).to receive(:query_slave_status).and_return slave_status_row
+      expect(checker).to receive(testdata[3])
       begin
-        allow(checker).to receive(:open_connection) # do nothing
-        allow(checker).to receive(:query_slave_status).and_return slave_status_row
         checker.run
       rescue SystemExit => e
-        exit_code = e.status
       end
-      expect(exit_code).to eq testdata[3]
     end
   end
 
   [
-    [0, :ok, 0, 'ok'],
-    [99_999, :ok, 2, 'critical'],
-    [0, :critical, 2, 'critical'],
+    [0, :ok, :ok, 'slave running: true, replication delayed by 0, with max. outlier at 100000'],
+    [99_999, :ok, :critical, 'replication delayed by 99999, with max. outlier at 100000'],
+    [0, :critical, :critical, 'replication delayed by 0, with max. outlier at 100000'],
   ].each do |testdata|
-    it "sleeps with lag outlier protection and returns #{testdata[3]} (using default threshold)" do
+    it "sleeps with lag outlier protection and returns #{testdata[2]} (using default thresholds)" do
       checker.config[:lag_outlier_retry] = 1
       checker.config[:lag_outlier_sleep] = 10
       checker.config[:lag_outlier_report] = testdata[1]
@@ -107,15 +107,14 @@ def checker.critical(*_args)
         }
       ]
 
+      allow(checker).to receive(:open_connection) # do nothing
+      allow(checker).to receive(:query_slave_status).and_return slave_status_row[0], slave_status_row[1]
+      expect(checker).to receive(:sleep).with(10)
+      expect(checker).to receive(testdata[2]).with(testdata[3]).once
       begin
-        allow(checker).to receive(:open_connection) # do nothing
-        allow(checker).to receive(:query_slave_status).and_return slave_status_row[0], slave_status_row[1]
-        expect(checker).to receive(:sleep).with(10)
         checker.run
       rescue SystemExit => e
-        exit_code = e.status
       end
-      expect(exit_code).to eq testdata[2]
     end
   end
 end