check-mysql-replication-status: address RuboCop findings

Author: Jan Kunzmann

bin/check-mysql-replication-status.rb

@@ -103,7 +103,7 @@ class CheckMysqlReplicationStatus < Sensu::Plugin::Check::CLI
   option :lag_outlier_threshold,
          long: '--lag-outlier-threshold=VALUE',
          description: 'Lag threshold to trigger outlier protection',
-         default: 100000,
+         default: 100_000,
          proc: proc { |s| s.to_i }
 
   option :lag_outlier_sleep,
@@ -117,8 +117,7 @@ class CheckMysqlReplicationStatus < Sensu::Plugin::Check::CLI
          description: 'Level to report lag outlier',
          default: :ok,
          proc: proc(&:to_sym),
-         in: %i(ok warning critical)
-
+         in: %i[ok warning critical]
 
   def detect_replication_status?(row)
     %w[
@@ -166,7 +165,7 @@ def query_slave_status(db)
             "SHOW SLAVE '#{db_conn}' STATUS"
           end
     result = db.query sql
-    if result.nil? || result.size < 1
+    if result.nil? || result.count == 0
       nil
     else
       result.fetch_hash
@@ -193,7 +192,7 @@ def ok_slave_message
     db_conn = config[:master_connection]
 
     if db_conn.nil?
-      "slave running: true"
+      'slave running: true'
     else
       "master connection: #{db_conn}, slave running: true"
     end
@@ -203,7 +202,7 @@ def run
     db = open_connection
 
     retries = config[:lag_outlier_retry]
-    unknown "Invalid value for --lag-outlier-retry" if retries < 0
+    unknown 'Invalid value for --lag-outlier-retry' if retries < 0
 
     lag_outlier = 0
 
@@ -233,7 +232,7 @@ def run
       critical message if config[:lag_outlier_report] == :critical
       warning message if config[:lag_outlier_report] == :warning
     else
-      # TODO (breaking change): Thresholds are exclusive which is not consistent with all other checks
+      # TODO: (breaking change) Thresholds are exclusive which is not consistent with all other checks
       critical message if replication_delay > config[:crit]
       warning message if replication_delay > config[:warn]
     end

test/check-mysql-replication-status_spec.rb

@@ -29,6 +29,7 @@
 require_relative '../bin/check-mysql-replication-status'
 require_relative './spec_helper.rb'
 
+# rubocop:disable Metrics/BlockLength
 describe CheckMysqlReplicationStatus do
   let(:checker) { described_class.new }
   let(:exit_code) { nil }
@@ -48,23 +49,23 @@ def checker.critical(*_args)
   end
 
   [
-    ['Yes', 'Yes',    0, 0, 'ok'],
-    ['No',  'Yes',  nil, 2, 'critical'],
-    ['Yes', 'No',   nil, 2, 'critical'],
-    ['No',  'No',   nil, 2, 'critical'],
-    ['Yes', 'Yes',  900, 0, 'ok'],
-    ['Yes', 'Yes',  901, 1, 'warning'],
+    ['Yes', 'Yes', 0, 0, 'ok'],
+    ['No',  'Yes', nil, 2, 'critical'],
+    ['Yes', 'No', nil, 2, 'critical'],
+    ['No',  'No',  nil, 2, 'critical'],
+    ['Yes', 'Yes', 900, 0, 'ok'],
+    ['Yes', 'Yes', 901, 1, 'warning'],
     ['Yes', 'Yes', 1800, 1, 'warning'],
     ['Yes', 'Yes', 1801, 2, 'critical'],
   ].each do |testdata|
     it "returns #{testdata[4]} for default thresholds" do
       slave_status_row = {
-        "Slave_IO_State" => '',
-        "Slave_IO_Running" => testdata[0],
-        "Slave_SQL_Running" => testdata[1],
-        "Last_IO_Error" => '',
-        "Last_SQL_Error" => '',
-        "Seconds_Behind_Master" => testdata[2]
+        'Slave_IO_State' => '',
+        'Slave_IO_Running' => testdata[0],
+        'Slave_SQL_Running' => testdata[1],
+        'Last_IO_Error' => '',
+        'Last_SQL_Error' => '',
+        'Seconds_Behind_Master' => testdata[2]
       }
       begin
         allow(checker).to receive(:open_connection) # do nothing
@@ -78,29 +79,29 @@ def checker.critical(*_args)
   end
 
   [
-    [    0, 0, 'ok'],
-    [99999, 2, 'critical'],
+    [0, 0, 'ok'],
+    [99_999, 2, 'critical'],
   ].each do |testdata|
     it "sleeps with lag outlier protection and returns #{testdata[2]} for default thresholds" do
       checker.config[:lag_outlier_retry] = 1
       checker.config[:lag_outlier_sleep] = 10
 
       slave_status_row = [
         {
-          "Slave_IO_State" => '',
-          "Slave_IO_Running" => 'Yes',
-          "Slave_SQL_Running" => 'Yes',
-          "Last_IO_Error" => '',
-          "Last_SQL_Error" => '',
-          "Seconds_Behind_Master" => 100000
+          'Slave_IO_State' => '',
+          'Slave_IO_Running' => 'Yes',
+          'Slave_SQL_Running' => 'Yes',
+          'Last_IO_Error' => '',
+          'Last_SQL_Error' => '',
+          'Seconds_Behind_Master' => 100_000
         },
         {
-          "Slave_IO_State" => '',
-          "Slave_IO_Running" => 'Yes',
-          "Slave_SQL_Running" => 'Yes',
-          "Last_IO_Error" => '',
-          "Last_SQL_Error" => '',
-          "Seconds_Behind_Master" => testdata[0]
+          'Slave_IO_State' => '',
+          'Slave_IO_Running' => 'Yes',
+          'Slave_SQL_Running' => 'Yes',
+          'Last_IO_Error' => '',
+          'Last_SQL_Error' => '',
+          'Seconds_Behind_Master' => testdata[0]
         }
       ]