Merge pull request #197 from sendbird/fix/handling-errors

[CLNP-5191] fix: added try/catch to unhandled errors

Author: bang9

packages/uikit-chat-hooks/src/channel/useGroupChannelMessages/useGroupChannelMessagesWithCollection.ts

@@ -71,18 +71,14 @@ export const useGroupChannelMessagesWithCollection: UseGroupChannelMessages = (s
     updateRefreshing,
   } = useChannelMessagesReducer(options?.sortComparator);
 
-  const channelMarkAsRead = async (source?: CollectionEventSource) => {
-    try {
-      switch (source) {
-        case CollectionEventSource.EVENT_MESSAGE_RECEIVED:
-        case CollectionEventSource.EVENT_MESSAGE_SENT_SUCCESS:
-        case CollectionEventSource.SYNC_MESSAGE_FILL:
-        case undefined:
-          await confirmAndMarkAsRead([channel]);
-          break;
-      }
-    } catch (e) {
-      Logger.warn('[useGroupChannelMessagesWithCollection/channelMarkAsRead]', e);
+  const channelMarkAsRead = (source?: CollectionEventSource) => {
+    switch (source) {
+      case CollectionEventSource.EVENT_MESSAGE_RECEIVED:
+      case CollectionEventSource.EVENT_MESSAGE_SENT_SUCCESS:
+      case CollectionEventSource.SYNC_MESSAGE_FILL:
+      case undefined:
+        confirmAndMarkAsRead([channel]);
+        break;
     }
   };
   const updateNewMessagesReceived = (source: CollectionEventSource, messages: SendbirdBaseMessage[]) => {
@@ -105,7 +101,7 @@ export const useGroupChannelMessagesWithCollection: UseGroupChannelMessages = (s
     if (isNotEmpty(failedMessages)) updateMessages(failedMessages, false, sdk.currentUser?.userId);
   };
 
-  const init = useFreshCallback(async (startingPoint: number, limit: number, callback?: () => void) => {
+  const init = useFreshCallback((startingPoint: number, limit: number, callback?: () => void) => {
     if (collectionRef.current) collectionRef.current?.dispose();
 
     channelMarkAsRead();

packages/uikit-chat-hooks/src/channel/useGroupChannelMessages/useGroupChannelMessagesWithQuery.ts

@@ -53,17 +53,9 @@ export const useGroupChannelMessagesWithQuery: UseGroupChannelMessages = (sdk, c
     updateRefreshing,
   } = useChannelMessagesReducer(options?.sortComparator);
 
-  const channelMarkAsRead = async () => {
-    try {
-      await confirmAndMarkAsRead([channel]);
-    } catch (e) {
-      Logger.warn('[useGroupChannelMessagesWithQuery/channelMarkAsRead]', e);
-    }
-  };
-
   const init = useFreshCallback(async (uid?: string) => {
     if (uid) {
-      channelMarkAsRead();
+      confirmAndMarkAsRead([channel]);
       updateNewMessages([], true, sdk.currentUser?.userId);
 
       queryRef.current = createMessageQuery(channel, options);
@@ -86,7 +78,7 @@ export const useGroupChannelMessagesWithQuery: UseGroupChannelMessages = (sdk, c
       if (isDifferentChannel(channel, eventChannel)) return;
       if (isMyMessage(message, sdk.currentUser?.userId)) return;
 
-      channelMarkAsRead();
+      confirmAndMarkAsRead([channel]);
 
       updateMessages([message], false, sdk.currentUser?.userId);
       if (options?.shouldCountNewMessages?.()) {

packages/uikit-react-native/src/components/ChannelInput/VoiceMessageInput.tsx

@@ -10,7 +10,7 @@ import {
   createStyleSheet,
   useUIKitTheme,
 } from '@sendbird/uikit-react-native-foundation';
-import { conditionChaining, millsToMMSS } from '@sendbird/uikit-utils';
+import { Logger, conditionChaining, millsToMMSS } from '@sendbird/uikit-utils';
 
 import { useLocalization } from '../../hooks/useContext';
 import useVoiceMessageInput from '../../hooks/useVoiceMessageInput';
@@ -32,34 +32,50 @@ const VoiceMessageInput = ({ onClose, onSend }: VoiceMessageInputProps) => {
   const uiColors = colors.ui.voiceMessageInput.default[state.status !== 'idle' ? 'active' : 'inactive'];
 
   const onPressCancel = async () => {
-    actions.cancel();
-    onClose();
+    await actions
+      .cancel()
+      .catch((error) => {
+        Logger.warn('Failed to cancel voice message input', error);
+      })
+      .finally(() => {
+        onClose();
+      });
   };
 
   const onPressSend = async () => {
-    actions.send();
-    onClose();
+    await actions
+      .send()
+      .catch((error) => {
+        Logger.warn('Failed to send voice message', error);
+      })
+      .finally(() => {
+        onClose();
+      });
   };
 
-  const onPressVoiceMessageAction = () => {
-    switch (state.status) {
-      case 'idle':
-        actions.startRecording();
-        break;
-      case 'recording':
-        if (lessThanMinimumDuration) {
-          actions.cancel();
-        } else {
-          actions.stopRecording();
-        }
-        break;
-      case 'recording_completed':
-      case 'playing_paused':
-        actions.playPlayer();
-        break;
-      case 'playing':
-        actions.pausePlayer();
-        break;
+  const onPressVoiceMessageAction = async () => {
+    try {
+      switch (state.status) {
+        case 'idle':
+          await actions.startRecording();
+          break;
+        case 'recording':
+          if (lessThanMinimumDuration) {
+            await actions.cancel();
+          } else {
+            await actions.stopRecording();
+          }
+          break;
+        case 'recording_completed':
+        case 'playing_paused':
+          await actions.playPlayer();
+          break;
+        case 'playing':
+          await actions.pausePlayer();
+          break;
+      }
+    } catch (error) {
+      Logger.warn('Failed to run voice message action.', state);
     }
   };
   const renderActionIcon = () => {

packages/uikit-react-native/src/components/ChannelInput/index.tsx

@@ -4,6 +4,7 @@ import { useSafeAreaInsets } from 'react-native-safe-area-context';
 
 import { createStyleSheet, useUIKitTheme } from '@sendbird/uikit-react-native-foundation';
 import {
+  Logger,
   SendbirdBaseChannel,
   SendbirdBaseMessage,
   SendbirdFileMessage,
@@ -187,12 +188,21 @@ const ChannelInput = (props: ChannelInputProps) => {
 };
 
 const useTypingTrigger = (text: string, channel: SendbirdBaseChannel) => {
-  if (channel.isGroupChannel()) {
-    useEffect(() => {
-      if (text.length === 0) channel.endTyping();
-      else channel.startTyping();
-    }, [text]);
-  }
+  useEffect(
+    () => {
+      function triggerTyping() {
+        if (channel.isGroupChannel()) {
+          const action = text.length === 0 ? channel.endTyping : channel.startTyping;
+          action().catch((error) => {
+            Logger.debug('ChannelInput: Failed to trigger typing', error);
+          });
+        }
+      }
+
+      triggerTyping();
+    },
+    channel.isGroupChannel() ? [text] : [],
+  );
 };
 
 const useTextClearOnDisabled = (setText: (val: string) => void, chatDisabled: boolean) => {

packages/uikit-react-native/src/components/GroupChannelMessageRenderer/index.tsx

@@ -279,7 +279,7 @@ const GroupChannelMessageRenderer: GroupChannelProps['Fragment']['renderMessage'
             onUnsubscribeStatus={voiceMessageStatusManager.unsubscribe}
             onUnmount={() => {
               if (isVoiceMessage(message) && playerService.uri === message.url) {
-                resetPlayer();
+                resetPlayer().catch((_) => {});
               }
             }}
             {...messageProps}

packages/uikit-react-native/src/components/ReactionAddons/BottomSheetReactionAddon.tsx

@@ -5,7 +5,7 @@ import { useSafeAreaInsets } from 'react-native-safe-area-context';
 import type { BaseMessage } from '@sendbird/chat/message';
 import { useChannelHandler } from '@sendbird/uikit-chat-hooks';
 import { Icon, Image, createStyleSheet, useUIKitTheme } from '@sendbird/uikit-react-native-foundation';
-import { SendbirdBaseChannel, SendbirdBaseMessage, useUniqHandlerId } from '@sendbird/uikit-utils';
+import { Logger, SendbirdBaseChannel, SendbirdBaseMessage, useUniqHandlerId } from '@sendbird/uikit-utils';
 
 import { UNKNOWN_USER_ID } from '../../constants';
 import { useReaction, useSendbirdChat } from '../../hooks/useContext';
@@ -46,10 +46,15 @@ const BottomSheetReactionAddon = ({ onClose, message, channel }: Props) => {
         const currentUserIdx = reactionUserIds.indexOf(currentUser?.userId ?? UNKNOWN_USER_ID);
         const reacted = currentUserIdx > -1;
 
-        const onPress = () => {
-          if (reacted) channel.deleteReaction(message, key);
-          else channel.addReaction(message, key);
-          onClose();
+        const onPress = async () => {
+          const action = reacted ? channel.deleteReaction : channel.addReaction;
+          await action(message, key)
+            .catch((error) => {
+              Logger.warn('Failed to reaction', error);
+            })
+            .finally(() => {
+              onClose();
+            });
         };
 
         return (

packages/uikit-react-native/src/components/ReactionBottomSheets/ReactionListBottomSheet.tsx

@@ -3,6 +3,7 @@ import { FlatList, Pressable, View, useWindowDimensions } from 'react-native';
 import { useSafeAreaInsets } from 'react-native-safe-area-context';
 
 import { Image, Modal, createStyleSheet, useUIKitTheme } from '@sendbird/uikit-react-native-foundation';
+import { Logger } from '@sendbird/uikit-utils';
 
 import { UNKNOWN_USER_ID } from '../../constants';
 import type { ReactionBottomSheetProps } from './index';
@@ -53,12 +54,14 @@ const ReactionListBottomSheet = ({ visible, onClose, onDismiss, reactionCtx, cha
               <View style={styles.emojiItem}>
                 <Pressable
                   key={key}
-                  onPress={() => {
+                  onPress={async () => {
                     if (message && channel) {
-                      if (reacted) channel.deleteReaction(message, key);
-                      else channel.addReaction(message, key);
+                      const action = reacted ? channel.deleteReaction : channel.addReaction;
+                      action(message, key).catch((error) => {
+                        Logger.warn('Failed to reaction', error);
+                      });
                     }
-                    onClose();
+                    await onClose();
                   }}
                   style={({ pressed }) => [
                     styles.button,

packages/uikit-react-native/src/components/ThreadParentMessageRenderer/index.tsx

@@ -178,7 +178,7 @@ const ThreadParentMessageRenderer = (props: ThreadParentMessageRendererProps) =>
           durationMetaArrayKey={VOICE_MESSAGE_META_ARRAY_DURATION_KEY}
           onUnmount={() => {
             if (isVoiceMessage(parentMessage) && playerService.uri === parentMessage.url) {
-              resetPlayer();
+              resetPlayer().catch((_) => {});
             }
           }}
           {...messageProps}

packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx

@@ -40,7 +40,7 @@ const GroupChannelMessageList = (props: GroupChannelProps['MessageList']) => {
           if (focusAnimated) {
             props.onUpdateSearchItem({ startingPoint: createdAt });
           }
-          props.onResetMessageListWithStartingPoint(createdAt);
+          props.onResetMessageListWithStartingPoint(createdAt).catch((_) => {});
         } else {
           return false;
         }
@@ -54,7 +54,7 @@ const GroupChannelMessageList = (props: GroupChannelProps['MessageList']) => {
       props.onUpdateSearchItem(undefined);
       props.onScrolledAwayFromBottom(false);
 
-      await props.onResetMessageList();
+      await props.onResetMessageList().catch((_) => {});
       props.onScrolledAwayFromBottom(false);
       lazyScrollToBottom({ animated });
     } else {

packages/uikit-react-native/src/domain/groupChannelSettings/component/GroupChannelSettingsMenu.tsx

@@ -47,10 +47,14 @@ const GroupChannelSettingsMenu = ({
   }
 
   const toggleNotification = async () => {
-    if (channel.myPushTriggerOption === 'off') {
-      await channel.setMyPushTriggerOption(PushTriggerOption.DEFAULT);
-    } else {
-      await channel.setMyPushTriggerOption(PushTriggerOption.OFF);
+    try {
+      if (channel.myPushTriggerOption === 'off') {
+        await channel.setMyPushTriggerOption(PushTriggerOption.DEFAULT);
+      } else {
+        await channel.setMyPushTriggerOption(PushTriggerOption.OFF);
+      }
+    } catch (error) {
+      Logger.warn('Failed to toggle notification', error);
     }
   };