Skip to content
This repository was archived by the owner on Feb 10, 2022. It is now read-only.

Commit 75a04df

Browse files
committed
Avoid the reuse of the same name
1 parent 6775489 commit 75a04df

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

lib/components/Header.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,12 @@ export default class Header extends BaseElement {
5757
userDiv.appendChild(profileImg);
5858
userDiv.appendChild(headerInfo);
5959

60+
let userDivMenu;
6061
if (!this.args.isWidget) {
6162
const userDetail = userDiv.cloneNode(true);
6263
replaceClassName(userDetail, classes['userDiv'], classes['userDetail']);
6364

64-
userDiv = new Menu({
65+
userDivMenu = new Menu({
6566
element: userDiv,
6667
items: [
6768
{
@@ -100,8 +101,8 @@ export default class Header extends BaseElement {
100101
className: classes['headerDivider']
101102
});
102103

103-
if (userDiv instanceof BaseElement) {
104-
userDiv.appendToBaseElement(this);
104+
if (userDivMenu) {
105+
userDivMenu.appendToBaseElement(this);
105106
} else {
106107
this.element.appendChild(userDiv);
107108
}

0 commit comments

Comments
 (0)