Commit d9f8771
Sravan S
fix: Donot use cache in getByChannelUrl
* getByChannelUrl cache is disabled by default
* getByChannelUrl has two interfaces now:
```
getByChannelUrl(channelUrl: string, callback: TicketCallback): void;
getByChannelUrl(channelUrl: string, cachingEnabled: boolean , callback: TicketCallback): void;
```
* To use caching, use 2nd interface
Because there is no real time communication,
it doesnt really make sense to implement caching in Ticket API
To implement caching perfectly, we need to implement realtime
event handling.1 parent c3670d2 commit d9f8771
3 files changed
+3
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| 107 | + | |
107 | 108 | | |
108 | 109 | | |
109 | 110 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
0 commit comments