Skip to content

Commit d9f8771

Browse files
author
Sravan S
committed
fix: Donot use cache in getByChannelUrl
* getByChannelUrl cache is disabled by default * getByChannelUrl has two interfaces now: ``` getByChannelUrl(channelUrl: string, callback: TicketCallback): void; getByChannelUrl(channelUrl: string, cachingEnabled: boolean , callback: TicketCallback): void; ``` * To use caching, use 2nd interface Because there is no real time communication, it doesnt really make sense to implement caching in Ticket API To implement caching perfectly, we need to implement realtime event handling.
1 parent c3670d2 commit d9f8771

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

SendBird.Desk.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ declare namespace SendBirdDesk {
104104
): void;
105105
getOpenCount(callback: CommonCallback): void;
106106
getByChannelUrl(channelUrl: string, callback: TicketCallback): void;
107+
getByChannelUrl(channelUrl: string, cachingEnabled: boolean , callback: TicketCallback): void;
107108
getAllTickets(offset: number, callback: TicketArrayCallback): void;
108109
getAllTickets(offset: number, customFieldFilter: object, callback: TicketArrayCallback): void;
109110
getOpenedList(offset: number, callback: TicketArrayCallback): void;

SendBird.Desk.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "sendbird-desk",
3-
"version": "1.0.21",
3+
"version": "1.0.22",
44
"description": "SendBird Desk SDK Integration Guide for JavaScript =========== SendBird Desk is a chat customer service platform built on SendBird SDK and API.",
55
"main": "SendBird.Desk.min.js",
66
"scripts": {

0 commit comments

Comments
 (0)