-
Notifications
You must be signed in to change notification settings - Fork 108
update docs for bngd features #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Don't forget to add
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 96d0005 |
| 🔍 Latest deploy log | https://app.netlify.com/projects/semgrep-docs-prod/deploys/692ef61c0558110008b95154 |
| 😎 Deploy Preview | https://deploy-preview-2355--semgrep-docs-prod.netlify.app |
| 📱 Preview on mobile |
To edit notification comments on pull requests, go to your Netlify project configuration.
|
@khorne3 I don't see anything about the new "provisionally ignored" status. Am I just missing it? Let me know if you want me to provide a write up of what it is and how it works. |
|
@jsmoxon This was a WIP that I put on pause for a bit, so it doesn't have the provisionally ignored status info. If you could provide a write-up, that would be great. Thank you! |
abhijna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this massive project! I’ve left a few minor fix requests, but otherwise lgtm!
Co-authored-by: Abhijna Parigi <abhijna@semgrep.com>
…tps://github.com/semgrep/semgrep-docs into katiehorne/tec-430-update-docs-for-bngd-features
Co-authored-by: Abhijna Parigi <abhijna@semgrep.com>
Co-authored-by: Abhijna Parigi <abhijna@semgrep.com>
Co-authored-by: Abhijna Parigi <abhijna@semgrep.com>
Co-authored-by: Abhijna Parigi <abhijna@semgrep.com>
Co-authored-by: Abhijna Parigi <abhijna@semgrep.com>
…tps://github.com/semgrep/semgrep-docs into katiehorne/tec-430-update-docs-for-bngd-features
jsmoxon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments based on initial review! Overall good but it looks like some of the Provisionally Ignored status definitions are missing for Secrets and Supply Chain?
Notes for reviewers: there are a lot of docs included in the PR that can be ignored (e.g., they're just link updates, anchor tag fixes, 36ish deleted images, unused components removal, etc). Here's where you'll find info regarding the key BNGD components and where you should focus during the review:
New filters (LOTS of pages were updated due to the new filters and related UI changes)
Provisionally ignored status
Info on Priority findings vs. All findings
Custom priority
Please ensure