Skip to content

Conversation

@khorne3
Copy link
Collaborator

@khorne3 khorne3 commented Oct 17, 2025

Notes for reviewers: there are a lot of docs included in the PR that can be ignored (e.g., they're just link updates, anchor tag fixes, 36ish deleted images, unused components removal, etc). Here's where you'll find info regarding the key BNGD components and where you should focus during the review:

Please ensure

  • A subject matter expert (SME) reviews the content
  • A technical writer reviews the content or PR
  • This change has no security implications or else you have pinged the security team
  • Redirects are added if the PR changes page URLs
  • If you have changed any header tag links (doc/#this-kind-of-anchor), update all instances of that link

@netlify
Copy link

netlify bot commented Oct 17, 2025

Don't forget to add /docs at the end of the deploy preview site URL!

Name Link
🔨 Latest commit 96d0005
🔍 Latest deploy log https://app.netlify.com/projects/semgrep-docs-prod/deploys/692ef61c0558110008b95154
😎 Deploy Preview https://deploy-preview-2355--semgrep-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jsmoxon
Copy link
Collaborator

jsmoxon commented Nov 6, 2025

@khorne3 I don't see anything about the new "provisionally ignored" status. Am I just missing it? Let me know if you want me to provide a write up of what it is and how it works.

@khorne3
Copy link
Collaborator Author

khorne3 commented Nov 7, 2025

@jsmoxon This was a WIP that I put on pause for a bit, so it doesn't have the provisionally ignored status info. If you could provide a write-up, that would be great. Thank you!

@khorne3 khorne3 requested review from abhijna and jsmoxon November 24, 2025 16:35
@khorne3 khorne3 marked this pull request as ready for review November 24, 2025 16:36
Copy link
Collaborator

@abhijna abhijna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this massive project! I’ve left a few minor fix requests, but otherwise lgtm!

khorne3 and others added 14 commits December 1, 2025 08:59
Co-authored-by: Abhijna Parigi <abhijna@semgrep.com>
Co-authored-by: Abhijna Parigi <abhijna@semgrep.com>
Co-authored-by: Abhijna Parigi <abhijna@semgrep.com>
Co-authored-by: Abhijna Parigi <abhijna@semgrep.com>
Co-authored-by: Abhijna Parigi <abhijna@semgrep.com>
Co-authored-by: Abhijna Parigi <abhijna@semgrep.com>
Copy link
Collaborator

@jsmoxon jsmoxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments based on initial review! Overall good but it looks like some of the Provisionally Ignored status definitions are missing for Secrets and Supply Chain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants