fix: Use Node 8 promisify instead of pify

Author: pvdlg

lib/load/parser-config.js

@@ -1,5 +1,5 @@
+const {promisify} = require('util');
 const importFrom = require('import-from');
-const pify = require('pify');
 const {mergeWith} = require('lodash');
 const SemanticReleaseError = require('@semantic-release/error');
 const conventionalChangelogAngular = require('conventional-changelog-angular');
@@ -33,7 +33,7 @@ module.exports = async ({preset, config, parserOpts}) => {
   }
 
   if (typeof loadedConfig === 'function') {
-    loadedConfig = await pify(loadedConfig)();
+    loadedConfig = await promisify(loadedConfig)();
   } else {
     loadedConfig = await loadedConfig;
   }

package.json

@@ -16,8 +16,7 @@
     "conventional-changelog-angular": "^1.4.0",
     "conventional-commits-parser": "^2.0.0",
     "import-from": "^2.1.0",
-    "lodash": "^4.17.4",
-    "pify": "^3.0.0"
+    "lodash": "^4.17.4"
   },
   "devDependencies": {
     "ava": "^0.23.0",
@@ -40,8 +39,7 @@
     "nyc": "^11.1.0",
     "prettier": "^1.7.2",
     "rimraf": "^2.6.1",
-    "semantic-release": "^8.0.0",
-    "tempy": "^0.2.0"
+    "semantic-release": "^8.0.0"
   },
   "engines": {
     "node": ">=4"

test/integration.test.js

@@ -1,25 +1,25 @@
+import {promisify} from 'util';
 import test from 'ava';
-import pify from 'pify';
 import SemanticReleaseError from '@semantic-release/error';
 import commitAnalyzer from '../lib/index';
 
 test('Parse with "conventional-changelog-angular" by default', async t => {
   const commits = [{message: 'fix(scope1): First fix'}, {message: 'feat(scope2): Second feature'}];
-  const releaseType = await pify(commitAnalyzer)({}, {commits});
+  const releaseType = await promisify(commitAnalyzer)({}, {commits});
 
   t.is(releaseType, 'minor');
 });
 
 test('Accept "preset" option', async t => {
   const commits = [{message: 'Fix: First fix (fixes #123)'}, {message: 'Update: Second feature (fixes #456)'}];
-  const releaseType = await pify(commitAnalyzer)({preset: 'eslint'}, {commits});
+  const releaseType = await promisify(commitAnalyzer)({preset: 'eslint'}, {commits});
 
   t.is(releaseType, 'minor');
 });
 
 test('Accept "config" option', async t => {
   const commits = [{message: 'Fix: First fix (fixes #123)'}, {message: 'Update: Second feature (fixes #456)'}];
-  const releaseType = await pify(commitAnalyzer)({config: 'conventional-changelog-eslint'}, {commits});
+  const releaseType = await promisify(commitAnalyzer)({config: 'conventional-changelog-eslint'}, {commits});
 
   t.is(releaseType, 'minor');
 });
@@ -29,7 +29,7 @@ test('Accept a "parseOpts" object as option', async t => {
     {message: '##BUGFIX## First fix (fixes #123)'},
     {message: '##FEATURE## Second feature (fixes #456)'},
   ];
-  const releaseType = await pify(commitAnalyzer)(
+  const releaseType = await promisify(commitAnalyzer)(
     {parserOpts: {headerPattern: /^##(.*?)## (.*)$/, headerCorrespondence: ['tag', 'shortDesc']}},
     {commits}
   );
@@ -39,7 +39,7 @@ test('Accept a "parseOpts" object as option', async t => {
 
 test('Accept a partial "parseOpts" object as option', async t => {
   const commits = [{message: '##fix## First fix (fixes #123)'}, {message: '##Update## Second feature (fixes #456)'}];
-  const releaseType = await pify(commitAnalyzer)(
+  const releaseType = await promisify(commitAnalyzer)(
     {
       config: 'conventional-changelog-eslint',
       parserOpts: {headerPattern: /^##(.*?)## (.*)$/, headerCorrespondence: ['type', 'shortDesc']},
@@ -52,7 +52,7 @@ test('Accept a partial "parseOpts" object as option', async t => {
 
 test('Accept a "releaseRules" option that reference a requierable module', async t => {
   const commits = [{message: 'fix(scope1): First fix'}, {message: 'feat(scope2): Second feature'}];
-  const releaseType = await pify(commitAnalyzer)({releaseRules: './test/fixtures/release-rules'}, {commits});
+  const releaseType = await promisify(commitAnalyzer)({releaseRules: './test/fixtures/release-rules'}, {commits});
 
   t.is(releaseType, 'minor');
 });
@@ -62,21 +62,21 @@ test('Return "major" if there is a breaking change, using default releaseRules',
     {message: 'Fix: First fix (fixes #123)'},
     {message: 'Update: Second feature (fixes #456) \n\n BREAKING CHANGE: break something'},
   ];
-  const releaseType = await pify(commitAnalyzer)({preset: 'eslint'}, {commits});
+  const releaseType = await promisify(commitAnalyzer)({preset: 'eslint'}, {commits});
 
   t.is(releaseType, 'major');
 });
 
 test('Return "patch" if there is only types set to "patch", using default releaseRules', async t => {
   const commits = [{message: 'fix: First fix (fixes #123)'}, {message: 'perf: perf improvement'}];
-  const releaseType = await pify(commitAnalyzer)({}, {commits});
+  const releaseType = await promisify(commitAnalyzer)({}, {commits});
 
   t.is(releaseType, 'patch');
 });
 
 test('Allow to use regex in "releaseRules" configuration', async t => {
   const commits = [{message: 'Chore: First chore (fixes #123)'}, {message: 'Docs: update README (fixes #456)'}];
-  const releaseType = await pify(commitAnalyzer)(
+  const releaseType = await promisify(commitAnalyzer)(
     {
       preset: 'eslint',
       releaseRules: [{tag: 'Chore', release: 'patch'}, {message: '/README/', release: 'minor'}],
@@ -89,14 +89,14 @@ test('Allow to use regex in "releaseRules" configuration', async t => {
 
 test('Return "null" if no rule match', async t => {
   const commits = [{message: 'doc: doc update'}, {message: 'chore: Chore'}];
-  const releaseType = await pify(commitAnalyzer)({}, {commits});
+  const releaseType = await promisify(commitAnalyzer)({}, {commits});
 
   t.is(releaseType, null);
 });
 
 test('Process rules in order and apply highest match', async t => {
   const commits = [{message: 'Chore: First chore (fixes #123)'}, {message: 'Docs: update README (fixes #456)'}];
-  const releaseType = await pify(commitAnalyzer)(
+  const releaseType = await promisify(commitAnalyzer)(
     {preset: 'eslint', releaseRules: [{tag: 'Chore', release: 'minor'}, {tag: 'Chore', release: 'patch'}]},
     {commits}
   );
@@ -109,7 +109,7 @@ test('Process rules in order and apply highest match from config even if default
     {message: 'Chore: First chore (fixes #123)'},
     {message: 'Docs: update README (fixes #456) \n\n BREAKING CHANGE: break something'},
   ];
-  const releaseType = await pify(commitAnalyzer)(
+  const releaseType = await promisify(commitAnalyzer)(
     {preset: 'eslint', releaseRules: [{tag: 'Chore', release: 'patch'}, {breaking: true, release: 'minor'}]},
     {commits}
   );
@@ -119,7 +119,7 @@ test('Process rules in order and apply highest match from config even if default
 
 test('Use default "releaseRules" if none of provided match', async t => {
   const commits = [{message: 'Chore: First chore'}, {message: 'Update: new feature'}];
-  const releaseType = await pify(commitAnalyzer)(
+  const releaseType = await promisify(commitAnalyzer)(
     {preset: 'eslint', releaseRules: [{tag: 'Chore', release: 'patch'}]},
     {commits}
   );
@@ -129,14 +129,14 @@ test('Use default "releaseRules" if none of provided match', async t => {
 
 test('Ignore malformatted commits and process valid ones', async t => {
   const commits = [{message: 'fix(scope1): First fix'}, {message: 'Feature => Invalid message'}];
-  const releaseType = await pify(commitAnalyzer)({}, {commits});
+  const releaseType = await promisify(commitAnalyzer)({}, {commits});
 
   t.is(releaseType, 'patch');
 });
 
 test('Throw "SemanticReleaseError" if "preset" doesn`t exist', async t => {
   const error = await t.throws(
-    pify(commitAnalyzer)({preset: 'unknown-preset'}, {}),
+    promisify(commitAnalyzer)({preset: 'unknown-preset'}, {}),
     /Preset: "unknown-preset" does not exist:/
   );
 
@@ -146,7 +146,7 @@ test('Throw "SemanticReleaseError" if "preset" doesn`t exist', async t => {
 
 test('Throw "SemanticReleaseError" if "releaseRules" is not an Array or a String', async t => {
   const error = await t.throws(
-    pify(commitAnalyzer)({releaseRules: {}}, {}),
+    promisify(commitAnalyzer)({releaseRules: {}}, {}),
     /Error in commit-analyzer configuration: "releaseRules" must be an array of rules/
   );
 
@@ -156,7 +156,7 @@ test('Throw "SemanticReleaseError" if "releaseRules" is not an Array or a String
 
 test('Throw "SemanticReleaseError" if "releaseRules" option reference a requierable module that is not an Array or a String', async t => {
   const error = await t.throws(
-    pify(commitAnalyzer)({releaseRules: './test/fixtures/release-rules-invalid'}, {}),
+    promisify(commitAnalyzer)({releaseRules: './test/fixtures/release-rules-invalid'}, {}),
     /Error in commit-analyzer configuration: "releaseRules" must be an array of rules/
   );
 
@@ -167,7 +167,7 @@ test('Throw "SemanticReleaseError" if "releaseRules" option reference a requiera
 test('Throw "SemanticReleaseError" if "config" doesn`t exist', async t => {
   const commits = [{message: 'Fix: First fix (fixes #123)'}, {message: 'Update: Second feature (fixes #456)'}];
   const error = await t.throws(
-    pify(commitAnalyzer)({config: 'unknown-config'}, {commits}),
+    promisify(commitAnalyzer)({config: 'unknown-config'}, {commits}),
     /Config: "unknown-config" does not exist:/
   );
 
@@ -177,7 +177,7 @@ test('Throw "SemanticReleaseError" if "config" doesn`t exist', async t => {
 
 test('Throw "SemanticReleaseError" if "releaseRules" reference invalid commit type', async t => {
   const error = await t.throws(
-    pify(commitAnalyzer)({preset: 'eslint', releaseRules: [{tag: 'Update', release: 'invalid'}]}, {}),
+    promisify(commitAnalyzer)({preset: 'eslint', releaseRules: [{tag: 'Update', release: 'invalid'}]}, {}),
     /Error in commit-analyzer configuration: "invalid" is not a valid release type\. Valid values are:\[?.*\]/
   );
 
@@ -188,7 +188,7 @@ test('Throw "SemanticReleaseError" if "releaseRules" reference invalid commit ty
 test('Handle error in "conventional-changelog-parser" and wrap in "SemanticReleaseError"', async t => {
   const commits = [{message: 'Fix: First fix (fixes #123)'}, {message: 'Update: Second feature (fixes #456)'}];
   const error = await t.throws(
-    pify(commitAnalyzer)({parserOpts: {headerPattern: '\\'}}, {commits}),
+    promisify(commitAnalyzer)({parserOpts: {headerPattern: '\\'}}, {commits}),
     /Error in conventional-changelog-parser: Invalid regular expression:/
   );
 
@@ -197,7 +197,7 @@ test('Handle error in "conventional-changelog-parser" and wrap in "SemanticRelea
 
 test('Accept an undefined "pluginConfig"', async t => {
   const commits = [{message: 'fix(scope1): First fix'}, {message: 'feat(scope2): Second feature'}];
-  const releaseType = await pify(commitAnalyzer)(undefined, {commits});
+  const releaseType = await promisify(commitAnalyzer)(undefined, {commits});
 
   t.is(releaseType, 'minor');
 });