fix: Throw error if a release rule is invalid

Author: pvdlg

lib/analyze-commit.js

@@ -24,7 +24,7 @@ module.exports = (releaseRules, commit) => {
         )
     )
     .every(match => {
-      if (match && compareReleaseTypes(releaseType, match.release)) {
+      if (compareReleaseTypes(releaseType, match.release)) {
         releaseType = match.release;
         if (releaseType === RELEASE_TYPES[0]) {
           return false;

lib/load/release-rules.js

@@ -24,7 +24,9 @@ module.exports = ({releaseRules}) => {
     }
 
     loadedReleaseRules.forEach(rule => {
-      if (RELEASE_TYPES.indexOf(rule.release) === -1) {
+      if (!rule || !rule.release) {
+        throw new Error('Error in commit-analyzer configuration: rules must be an object with a "release" property');
+      } else if (RELEASE_TYPES.indexOf(rule.release) === -1) {
         throw new Error(
           `Error in commit-analyzer configuration: "${rule.release}" is not a valid release type. Valid values are: ${JSON.stringify(
             RELEASE_TYPES

test/load-release-rules.test.js

@@ -25,7 +25,13 @@ test('Throw error if "releaseRules" reference invalid commit type', t => {
     () => loadReleaseRules({releaseRules: [{tag: 'Update', release: 'invalid'}]}),
     /Error in commit-analyzer configuration: "invalid" is not a valid release type\. Valid values are:\[?.*\]/
   );
+});
 
+test('Throw error if a rule in "releaseRules" does not have a release type', t => {
+  t.throws(
+    () => loadReleaseRules({releaseRules: [{tag: 'Update'}]}),
+    /Error in commit-analyzer configuration: rules must be an object with a "release" property/
+  );
 });
 
 test('Throw error if "releaseRules" is not an Array or a String', t => {
@@ -40,5 +46,11 @@ test('Throw error if "releaseRules" option reference a requierable module that i
     () => loadReleaseRules({releaseRules: './test/fixtures/release-rules-invalid'}),
     /Error in commit-analyzer configuration: "releaseRules" must be an array of rules/
   );
+});
 
+test('Throw error if "releaseRules" contains an undefined rule', t => {
+  t.throws(
+    () => loadReleaseRules({releaseRules: [{type: 'feat', release: 'minor'}, undefined]}, {}),
+    /Error in commit-analyzer configuration: rules must be an object with a "release" property/
+  );
 });