Treat the Chromium Edge browser like Chrome

Author: mdmintz

seleniumbase/core/browser_launcher.py

@@ -355,11 +355,12 @@ def get_driver(browser_name, headless=False, use_grid=False,
                     'The format for using a proxy server with authentication '
                     'is: "username:password@hostname:port". If using a proxy '
                     'server without auth, the format is: "hostname:port".')
-            if browser_name != constants.Browser.GOOGLE_CHROME:
+            if browser_name != constants.Browser.GOOGLE_CHROME and (
+                    browser_name != constants.Browser.EDGE):
                 raise Exception(
-                    "Chrome is required when using a proxy server that has "
-                    "authentication! (If using a proxy server without auth, "
-                    "either Chrome or Firefox may be used.)")
+                    "Chrome or Edge is required when using a proxy server "
+                    "that has authentication! (If using a proxy server "
+                    "without auth, Chrome, Edge, or Firefox may be used.)")
         proxy_string = validate_proxy_string(proxy_string)
         if proxy_string and proxy_user and proxy_pass:
             proxy_auth = True

seleniumbase/fixtures/base_case.py

@@ -1502,7 +1502,7 @@ def get_new_driver(self, browser=None, headless=None,
                     # WebDrivers can get closed during tearDown().
                     pass
             else:
-                if self.browser == 'chrome':
+                if self.browser == 'chrome' or self.browser == 'edge':
                     width = settings.CHROME_START_WIDTH
                     height = settings.CHROME_START_HEIGHT
                     try:
@@ -1522,12 +1522,6 @@ def get_new_driver(self, browser=None, headless=None,
                             self.wait_for_ready_state_complete()
                         except Exception:
                             pass  # Keep existing browser resolution
-                elif self.browser == 'edge':
-                    try:
-                        self.driver.maximize_window()
-                        self.wait_for_ready_state_complete()
-                    except Exception:
-                        pass  # Keep existing browser resolution
             if self.start_page and len(self.start_page) >= 4:
                 if page_utils.is_valid_url(self.start_page):
                     self.open(self.start_page)
@@ -2299,9 +2293,10 @@ def assert_no_js_errors(self):
             current_url = self.get_current_url()
             raise Exception(
                 "JavaScript errors found on %s => %s" % (current_url, errors))
-        if self.demo_mode and self.browser == 'chrome':
-            messenger_post = ("ASSERT NO JS ERRORS")
-            self.__highlight_with_assert_success(messenger_post, "html")
+        if self.demo_mode:
+            if (self.browser == 'chrome' or self.browser == 'edge'):
+                messenger_post = ("ASSERT NO JS ERRORS")
+                self.__highlight_with_assert_success(messenger_post, "html")
 
     def __activate_html_inspector(self):
         self.wait_for_ready_state_complete()