Merge pull request #2604 from seleniumbase/fix-browser-detection-on-windows

Fix browser-version-detection on Windows

Author: mdmintz

requirements.txt

@@ -71,7 +71,7 @@ rich==13.7.1
 
 coverage==6.2;python_version<"3.7"
 coverage==7.2.7;python_version>="3.7" and python_version<"3.8"
-coverage==7.4.3;python_version>="3.8"
+coverage==7.4.4;python_version>="3.8"
 pytest-cov==4.0.0;python_version<"3.7"
 pytest-cov==4.1.0;python_version>="3.7"
 flake8==5.0.4;python_version<"3.9"

seleniumbase/__version__.py

@@ -1,2 +1,2 @@
 # seleniumbase package
-__version__ = "4.24.6"
+__version__ = "4.24.7"

seleniumbase/core/detect_b_ver.py

@@ -97,7 +97,7 @@ def linux_browser_apps_to_cmd(*apps):
 
 
 def chrome_on_linux_path(prefer_chromium=False):
-    if os_name() != "linux":
+    if os_name() != OSType.LINUX:
         return ""
     if prefer_chromium:
         paths = ["/bin/chromium", "/bin/chromium-browser"]
@@ -127,7 +127,7 @@ def chrome_on_linux_path(prefer_chromium=False):
 
 
 def edge_on_linux_path():
-    if os_name() != "linux":
+    if os_name() != OSType.LINUX:
         return ""
     paths = os.environ["PATH"].split(os.pathsep)
     binaries = []
@@ -144,7 +144,7 @@ def edge_on_linux_path():
 
 
 def chrome_on_windows_path():
-    if os_name() != "win32":
+    if os_name() != OSType.WIN:
         return ""
     candidates = []
     for item in map(
@@ -172,7 +172,7 @@ def chrome_on_windows_path():
 
 
 def edge_on_windows_path():
-    if os_name() != "win32":
+    if os_name() != OSType.WIN:
         return ""
     candidates = []
     for item in map(

setup.py

@@ -227,7 +227,7 @@
         # Usage: coverage run -m pytest; coverage html; coverage report
         "coverage": [
             'coverage==7.2.7;python_version<"3.8"',
-            'coverage==7.4.3;python_version>="3.8"',
+            'coverage==7.4.4;python_version>="3.8"',
             'pytest-cov==4.1.0',
         ],
         # pip install -e .[flake8]