Update CDP Mode

Author: mdmintz

seleniumbase/core/sb_cdp.py

@@ -519,7 +519,20 @@ def __get_attribute(self, element, attribute):
         try:
             return element.get_js_attributes()[attribute]
         except Exception:
-            return None
+            if not attribute:
+                raise
+            try:
+                attribute_str = element.get_js_attributes()
+                locate = ' %s="' % attribute
+                if locate in attribute_str.outerHTML:
+                    outer_html = attribute_str.outerHTML
+                    attr_start = outer_html.find(locate) + len(locate)
+                    attr_end = outer_html.find('"', attr_start)
+                    value = outer_html[attr_start:attr_end]
+                    return value
+            except Exception:
+                pass
+        return None
 
     def __get_x_scroll_offset(self):
         x_scroll_offset = self.loop.run_until_complete(
@@ -620,11 +633,12 @@ def click_active_element(self):
 
     def click_if_visible(self, selector):
         if self.is_element_visible(selector):
-            element = self.find_element(selector)
-            element.scroll_into_view()
-            element.click()
-            self.__slow_mode_pause_if_set()
-            self.loop.run_until_complete(self.page.wait())
+            with suppress(Exception):
+                element = self.find_element(selector, timeout=0)
+                element.scroll_into_view()
+                element.click()
+                self.__slow_mode_pause_if_set()
+                self.loop.run_until_complete(self.page.wait())
 
     def click_visible_elements(self, selector, limit=0):
         """Finds all matching page elements and clicks visible ones in order.
@@ -1094,7 +1108,14 @@ def get_element_attributes(self, selector):
         )
 
     def get_element_attribute(self, selector, attribute):
-        return self.get_element_attributes(selector)[attribute]
+        attributes = self.get_element_attributes(selector)
+        with suppress(Exception):
+            return attributes[attribute]
+        locate = ' %s="' % attribute
+        value = self.get_attribute(selector, attribute)
+        if not value and locate not in attributes:
+            raise KeyError(attribute)
+        return value
 
     def get_attribute(self, selector, attribute):
         return self.find_element(selector).get_attribute(attribute)

seleniumbase/undetected/cdp_driver/_contradict.py

@@ -31,12 +31,12 @@ class ContraDict(dict):
 
     def __init__(self, *args, **kwargs):
         super().__init__()
-        silent = kwargs.pop("silent", False)
+        # silent = kwargs.pop("silent", False)
         _ = dict(*args, **kwargs)
 
         super().__setattr__("__dict__", self)
         for k, v in _.items():
-            _check_key(k, self, False, silent)
+            _check_key(k, self, False, True)
             super().__setitem__(k, _wrap(self.__class__, v))
 
     def __setitem__(self, key, value):
@@ -90,7 +90,7 @@ def _wrap(cls, v):
 
 
 def _check_key(
-    key: str, mapping: _Mapping, boolean: bool = False, silent=False
+    key: str, mapping: _Mapping, boolean: bool = False, silent=True
 ):
     """Checks `key` and warns if needed.
     :param key:

seleniumbase/undetected/cdp_driver/browser.py

@@ -10,6 +10,7 @@
 import pickle
 import re
 import shutil
+import time
 import urllib.parse
 import urllib.request
 import warnings
@@ -30,8 +31,6 @@ def get_registered_instances():
 
 
 def deconstruct_browser():
-    import time
-
     for _ in __registered__instances__:
         if not _.stopped:
             _.stop()
@@ -117,8 +116,13 @@ async def create(
                 port=port,
                 **kwargs,
             )
-        instance = cls(config)
-        await instance.start()
+        try:
+            instance = cls(config)
+            await instance.start()
+        except Exception:
+            time.sleep(0.15)
+            instance = cls(config)
+            await instance.start()
         return instance
 
     def __init__(self, config: Config, **kwargs):
@@ -379,8 +383,6 @@ async def start(self=None) -> Browser:
                     --------------------------------
                     Failed to connect to the browser
                     --------------------------------
-                    Possibly because you are running as "root".
-                    If so, you may need to use no_sandbox=True.
                     """
                 )
             )