Merge pull request #473 from seleniumbase/improve-method-reliability

Improve method reliability

Author: mdmintz

seleniumbase/fixtures/base_case.py

@@ -60,6 +60,7 @@ def test_anything(self):
 logging.getLogger("urllib3").setLevel(logging.ERROR)
 urllib3.disable_warnings()
 LOGGER.setLevel(logging.WARNING)
+ECI_Exception = selenium_exceptions.ElementClickInterceptedException
 ENI_Exception = selenium_exceptions.ElementNotInteractableException
 
 
@@ -951,10 +952,11 @@ def get_image_url(self, selector, by=By.CSS_SELECTOR, timeout=None):
 
     def find_elements(self, selector, by=By.CSS_SELECTOR, limit=0):
         """ Returns a list of matching WebElements.
+            Elements could be either hidden or visible on the page.
             If "limit" is set and > 0, will only return that many elements. """
-        self.wait_for_ready_state_complete()
-        time.sleep(0.05)
         selector, by = self.__recalculate_selector(selector, by)
+        self.wait_for_ready_state_complete()
+        time.sleep(0.07)
         elements = self.driver.find_elements(by=by, value=selector)
         if limit and limit > 0 and len(elements) > limit:
             elements = elements[:limit]
@@ -963,9 +965,9 @@ def find_elements(self, selector, by=By.CSS_SELECTOR, limit=0):
     def find_visible_elements(self, selector, by=By.CSS_SELECTOR, limit=0):
         """ Returns a list of matching WebElements that are visible.
             If "limit" is set and > 0, will only return that many elements. """
-        self.wait_for_ready_state_complete()
-        time.sleep(0.05)
         selector, by = self.__recalculate_selector(selector, by)
+        self.wait_for_ready_state_complete()
+        time.sleep(0.07)
         v_elems = page_actions.find_visible_elements(self.driver, selector, by)
         if limit and limit > 0 and len(v_elems) > limit:
             v_elems = v_elems[:limit]
@@ -977,35 +979,34 @@ def click_visible_elements(self, selector, by=By.CSS_SELECTOR, limit=0):
             Works best for actions such as clicking all checkboxes on a page.
             Example:  self.click_visible_elements('input[type="checkbox"]')
             If "limit" is set and > 0, will only click that many elements. """
-        elements = self.find_elements(selector, by=by)
-        count = 0
+        elements = []
+        try:
+            elements = self.find_visible_elements(selector, by=by)
+        except Exception:
+            elements = self.find_elements(selector, by=by)
         click_count = 0
         for element in elements:
             if limit and limit > 0 and click_count >= limit:
                 return
-            count += 1
-            if count == 1:
-                self.wait_for_ready_state_complete()
-                if self.is_element_visible(selector, by=by):
-                    self.click(selector, by=by)
+            try:
+                if element.is_displayed():
+                    self.__scroll_to_element(element)
+                    element.click()
                     click_count += 1
-            else:
+                    self.wait_for_ready_state_complete()
+            except ECI_Exception:
+                continue  # ElementClickInterceptedException (Overlay likely)
+            except (StaleElementReferenceException, ENI_Exception):
                 self.wait_for_ready_state_complete()
+                time.sleep(0.03)
                 try:
                     if element.is_displayed():
                         self.__scroll_to_element(element)
                         element.click()
                         click_count += 1
+                        self.wait_for_ready_state_complete()
                 except (StaleElementReferenceException, ENI_Exception):
-                    self.wait_for_ready_state_complete()
-                    time.sleep(0.05)
-                    try:
-                        if element.is_displayed():
-                            self.__scroll_to_element(element)
-                            element.click()
-                            click_count += 1
-                    except (StaleElementReferenceException, ENI_Exception):
-                        return  # Probably on new page / Elements are all stale
+                    return  # Probably on new page / Elements are all stale
 
     def click_nth_visible_element(self, selector, number, by=By.CSS_SELECTOR):
         """ Finds all matching page elements and clicks the nth visible one.
@@ -1051,6 +1052,9 @@ def is_element_in_an_iframe(self, selector, by=By.CSS_SELECTOR):
                 iframe_identifier = iframe['name']
             elif iframe.has_attr('id') and len(iframe['id']) > 0:
                 iframe_identifier = iframe['id']
+            elif iframe.has_attr('class') and len(iframe['class']) > 0:
+                iframe_class = " ".join(iframe["class"])
+                iframe_identifier = '[class="%s"]' % iframe_class
             else:
                 continue
             self.switch_to_frame(iframe_identifier)

seleniumbase/fixtures/page_actions.py

@@ -24,6 +24,8 @@
 import sys
 import time
 import traceback
+from selenium.common.exceptions import StaleElementReferenceException
+from selenium.common import exceptions as selenium_exceptions
 from selenium.webdriver.common.by import By
 from selenium.webdriver.common.action_chains import ActionChains
 from selenium.webdriver.remote.errorhandler import ElementNotVisibleException
@@ -34,6 +36,7 @@
 from seleniumbase.config import settings
 from seleniumbase.core import log_helper
 from seleniumbase.fixtures import page_utils
+ENI_Exception = selenium_exceptions.ElementNotInteractableException
 
 
 def is_element_present(driver, selector, by=By.CSS_SELECTOR):
@@ -459,7 +462,17 @@ def find_visible_elements(driver, selector, by=By.CSS_SELECTOR):
     by - the type of selector being used (Default: By.CSS_SELECTOR)
     """
     elements = driver.find_elements(by=by, value=selector)
-    return [element for element in elements if element.is_displayed()]
+    try:
+        v_elems = [element for element in elements if element.is_displayed()]
+        return v_elems
+    except (StaleElementReferenceException, ENI_Exception):
+        time.sleep(0.1)
+        elements = driver.find_elements(by=by, value=selector)
+        v_elems = []
+        for element in elements:
+            if element.is_displayed():
+                v_elems.append(element)
+        return v_elems
 
 
 def save_screenshot(driver, name, folder=None):

setup.py

@@ -45,7 +45,7 @@
 
 setup(
     name='seleniumbase',
-    version='1.34.16',
+    version='1.34.17',
     description='Fast, Easy, and Reliable Browser Automation & Testing.',
     long_description=long_description,
     long_description_content_type='text/markdown',