Merge pull request #482 from seleniumbase/improve-select-methods

Improve select_option_by_*() methods

Author: mdmintz

requirements.txt

@@ -1,7 +1,7 @@
 pip>=19.3.1
 setuptools>=44.0.0;python_version<"3"
 setuptools>=45.0.0;python_version>="3"
-setuptools-scm>=3.3.3
+setuptools-scm>=3.4.0
 wheel>=0.33.6
 six==1.14.0
 nose==1.3.7
@@ -14,7 +14,7 @@ selenium==3.141.0
 pluggy>=0.13.1
 attrs>=19.3.0
 pytest>=4.6.9;python_version<"3"
-pytest>=5.3.2;python_version>="3"
+pytest>=5.3.3;python_version>="3"
 pytest-cov>=2.8.1
 pytest-forked>=1.1.3
 pytest-html==1.22.1;python_version<"3.6"

seleniumbase/fixtures/base_case.py

@@ -1223,9 +1223,12 @@ def __select_option(self, dropdown_selector, option,
             timeout = self.__get_new_timeout(timeout)
         if page_utils.is_xpath_selector(dropdown_selector):
             dropdown_by = By.XPATH
-        element = self.wait_for_element_visible(
+        self.wait_for_ready_state_complete()
+        element = self.wait_for_element_present(
             dropdown_selector, by=dropdown_by, timeout=timeout)
-        self.__demo_mode_highlight_if_active(dropdown_selector, dropdown_by)
+        if self.is_element_visible(dropdown_selector, by=dropdown_by):
+            self.__demo_mode_highlight_if_active(
+                dropdown_selector, dropdown_by)
         pre_action_url = self.driver.current_url
         try:
             if option_by == "index":
@@ -1237,7 +1240,7 @@ def __select_option(self, dropdown_selector, option,
         except (StaleElementReferenceException, ENI_Exception):
             self.wait_for_ready_state_complete()
             time.sleep(0.05)
-            element = self.wait_for_element_visible(
+            element = self.wait_for_element_present(
                 dropdown_selector, by=dropdown_by, timeout=timeout)
             if option_by == "index":
                 Select(element).select_by_index(option)

setup.py

@@ -45,7 +45,7 @@
 
 setup(
     name='seleniumbase',
-    version='1.34.21',
+    version='1.34.22',
     description='Fast, Easy, and Reliable Browser Automation & Testing.',
     long_description=long_description,
     long_description_content_type='text/markdown',
@@ -96,7 +96,7 @@
         'pluggy>=0.13.1',
         'attrs>=19.3.0',
         'pytest>=4.6.9;python_version<"3"',  # For Python 2 compatibility
-        'pytest>=5.3.2;python_version>="3"',
+        'pytest>=5.3.3;python_version>="3"',
         'pytest-cov>=2.8.1',
         'pytest-forked>=1.1.3',
         'pytest-html==1.22.1;python_version<"3.6"',