Refactor code with the "ruff" Python linter

Author: mdmintz

seleniumbase/behave/behave_sb.py

@@ -367,7 +367,7 @@ def get_configured_sb(context):
         # Handle: -D variables="{'KEY':'VALUE','KEY2':'VALUE2'}"
         if low_key == "variables":
             variables = userdata[key]
-            if variables and type(variables) is str and len(variables) > 0:
+            if variables and isinstance(variables, str) and len(variables) > 0:
                 bad_input = False
                 if (
                     not variables.startswith("{")
@@ -377,7 +377,7 @@ def get_configured_sb(context):
                 else:
                     try:
                         variables = ast.literal_eval(variables)
-                        if not type(variables) is dict:
+                        if not isinstance(variables, dict):
                             bad_input = True
                     except Exception:
                         bad_input = True

seleniumbase/console_scripts/sb_print.py

@@ -213,7 +213,7 @@ def main():
                         first_paren = line.find("(")
                         line1 = line[:first_paren + 1]
                         line2 = new_ws + line[first_paren + 1:]
-                        if not ("):") in line2:
+                        if ("):") not in line2:
                             new_sb_lines.append(line1)
                             if get_width(line2) + w > console_width:
                                 if line2.count('", "') == 1:
@@ -353,7 +353,7 @@ def main():
                         new_ws = line[0:whitespace] + "    "
                         line1 = line.split('("')[0] + "("
                         line2 = new_ws + '"' + line.split('("')[1]
-                        if not ("):") in line2:
+                        if ("):") not in line2:
                             new_sb_lines.append(line1)
                             if get_width(line2) + w > console_width:
                                 if line2.count('" in self.') == 1:
@@ -382,7 +382,7 @@ def main():
                         new_ws = line[0:whitespace] + "    "
                         line1 = line.split("('")[0] + "("
                         line2 = new_ws + "'" + line.split("('")[1]
-                        if not ("):") in line2:
+                        if ("):") not in line2:
                             new_sb_lines.append(line1)
                             if get_width(line2) + w > console_width:
                                 if line2.count("' in self.") == 1:
@@ -444,7 +444,7 @@ def main():
                                 continue
                         new_sb_lines.append(line2)
                         continue
-                    if line.count("(self.") == 1 and not ("):") in line:
+                    if line.count("(self.") == 1 and ("):") not in line:
                         whitespace = line_length2 - len(line.lstrip())
                         new_ws = line[0:whitespace] + "    "
                         line1 = line.split("(self.")[0] + "("
@@ -500,7 +500,7 @@ def main():
                             else:
                                 new_sb_lines.append(line2)
                             continue
-                    if line.count(" % ") == 1 and not ("):") in line:
+                    if line.count(" % ") == 1 and ("):") not in line:
                         whitespace = line_length2 - len(line.lstrip())
                         new_ws = line[0:whitespace] + "    "
                         line1 = line.split(" % ")[0] + " \\"
@@ -509,7 +509,7 @@ def main():
                             new_sb_lines.append(line1)
                             new_sb_lines.append(line2)
                             continue
-                    if line.count(" = ") == 1 and not ("  # ") in line:
+                    if line.count(" = ") == 1 and ("  # ") not in line:
                         whitespace = line_length2 - len(line.lstrip())
                         new_ws = line[0:whitespace] + "    "
                         line1 = line.split(" = ")[0] + " = ("

seleniumbase/core/browser_launcher.py

@@ -361,9 +361,9 @@ def uc_special_open_if_cf(
                     driver.switch_to.window(driver.window_handles[-1])
                     uc_metrics = {}
                     if (
-                        type(device_width) is int
-                        and type(device_height) is int
-                        and type(device_pixel_ratio) is int
+                        isinstance(device_width, int)
+                        and isinstance(device_height, int)
+                        and isinstance(device_pixel_ratio, int)
                     ):
                         uc_metrics["width"] = device_width
                         uc_metrics["height"] = device_height
@@ -847,9 +847,9 @@ def _set_chrome_options(
         emulator_settings = {}
         device_metrics = {}
         if (
-            type(device_width) is int
-            and type(device_height) is int
-            and type(device_pixel_ratio) is int
+            isinstance(device_width, int)
+            and isinstance(device_height, int)
+            and isinstance(device_pixel_ratio, int)
         ):
             device_metrics["width"] = device_width
             device_metrics["height"] = device_height
@@ -1389,7 +1389,7 @@ def get_driver(
         headless = True
     if (
         binary_location
-        and type(binary_location) is str
+        and isinstance(binary_location, str)
         and (
             browser_name == constants.Browser.GOOGLE_CHROME
             or browser_name == constants.Browser.EDGE
@@ -2553,9 +2553,9 @@ def get_local_driver(
             emulator_settings = {}
             device_metrics = {}
             if (
-                type(device_width) is int
-                and type(device_height) is int
-                and type(device_pixel_ratio) is int
+                isinstance(device_width, int)
+                and isinstance(device_height, int)
+                and isinstance(device_pixel_ratio, int)
             ):
                 device_metrics["width"] = device_width
                 device_metrics["height"] = device_height
@@ -3703,9 +3703,9 @@ def get_local_driver(
                     if mobile_emulator:
                         uc_metrics = {}
                         if (
-                            type(device_width) is int
-                            and type(device_height) is int
-                            and type(device_pixel_ratio) is int
+                            isinstance(device_width, int)
+                            and isinstance(device_height, int)
+                            and isinstance(device_pixel_ratio, int)
                         ):
                             uc_metrics["width"] = device_width
                             uc_metrics["height"] = device_height

seleniumbase/core/jqc_helper.py

@@ -118,9 +118,7 @@ def jquery_confirm_text_dialog(driver, message, button=None, options=None):
     if not message:
         message = ""
     if button:
-        if not type(button) is list and not type(button) is tuple:
-            raise Exception('"button" should be a (text, color) tuple!')
-        if len(button) != 2:
+        if not isinstance(button, (list, tuple)) or len(button) != 2:
             raise Exception('"button" should be a (text, color) tuple!')
     else:
         button = ("Submit", "blue")