Merge pull request ClickHouse#288 from jtroy/exception-stay-open

Don't close the connection after a server exception is received.

Author: kshvakov

bootstrap.go

@@ -207,6 +207,7 @@ func open(dsn string) (*clickhouse, error) {
 	ch.encoder = binary.NewEncoderWithCompress(ch.buffer)
 
 	if err := ch.hello(database, username, password); err != nil {
+		ch.conn.Close()
 		return nil, err
 	}
 	return &ch, nil
@@ -245,7 +246,6 @@ func (ch *clickhouse) hello(database, username, password string) error {
 			ch.logf("[bootstrap] <- end of stream")
 			return nil
 		default:
-			ch.conn.Close()
 			return fmt.Errorf("[hello] unexpected packet [%d] from server", packet)
 		}
 	}

clickhouse_exception.go

@@ -18,7 +18,6 @@ func (e *Exception) Error() string {
 }
 
 func (ch *clickhouse) exception() error {
-	defer ch.conn.Close()
 	var (
 		e         Exception
 		err       error