do not calculate day count twice

veqryn · farbodsalimi · commit 3afaf9c47c38 · 2022-05-18T11:30:36.000-07:00
diff --git a/helpers.go b/helpers.go
@@ -134,8 +134,8 @@ func quote(v driver.Value) string {
 
 func formatTime(value time.Time) string {
 	// toDate() overflows after 65535 days, but toDateTime() only overflows when time.Time overflows (after 9223372036854775807 seconds)
-	if (value.Hour()+value.Minute()+value.Second()+value.Nanosecond()) == 0 && value.Unix()/24/3600 <= math.MaxUint16 {
-		return fmt.Sprintf("toDate(%d)", value.Unix()/24/3600)
+	if days := value.Unix() / 24 / 3600; days <= math.MaxUint16 && (value.Hour()+value.Minute()+value.Second()+value.Nanosecond()) == 0 {
+		return fmt.Sprintf("toDate(%d)", days)
 	}
 	return fmt.Sprintf("toDateTime(%d)", value.Unix())
 }

Original file line number	Diff line number	Diff line change
`@@ -134,8 +134,8 @@ func quote(v driver.Value) string {`
`134`	`134`
`135`	`135`	`func formatTime(value time.Time) string {`
`136`	`136`	`// toDate() overflows after 65535 days, but toDateTime() only overflows when time.Time overflows (after 9223372036854775807 seconds)`
`137`		`- if (value.Hour()+value.Minute()+value.Second()+value.Nanosecond()) == 0 && value.Unix()/24/3600 <= math.MaxUint16 {`
`138`		`- return fmt.Sprintf("toDate(%d)", value.Unix()/24/3600)`
	`137`	`+ if days := value.Unix() / 24 / 3600; days <= math.MaxUint16 && (value.Hour()+value.Minute()+value.Second()+value.Nanosecond()) == 0 {`
	`138`	`+ return fmt.Sprintf("toDate(%d)", days)`
`139`	`139`	`}`
`140`	`140`	`return fmt.Sprintf("toDateTime(%d)", value.Unix())`
`141`	`141`	`}`