Fix UUID (#557)

* Send uuid along with experiment id and variation name and call identify

* call identify only once per load

* updated version and HISTORY.md

* stub for identify

* Fix failing tests

* added test cases for identify method

* added vwoUserId as a trait in identify call

* added vwoUserId as a trait in identify call
Testing completed successfully on local machine, added test cases for identify method calls

Co-authored-by: Gaurishanker Gaur <gaurishanker.gaur@wingify.com>
Co-authored-by: Gaurav Nanda <gaurav.nanda@wingify.com>
Co-authored-by: dsjackins <daniel.jackins@segment.com>

Author: 4 people

integrations/visual-website-optimizer/HISTORY.md

@@ -1,3 +1,9 @@
+2.4.2 / 2021-02-09
+==================
+
+  * Send VWO UUID in every track call.
+  * Send identify call once every page load.
+
 2.4.1 / 2019-12-04
 ==================
 

integrations/visual-website-optimizer/lib/index.js

@@ -19,6 +19,7 @@ var VWO = (module.exports = integration('Visual Website Optimizer')
   .global('_vis_opt_revenue_conversion')
   .global('_vwo_exp')
   .global('_vwo_exp_ids')
+  .global('VWO')
   .option('accountId')
   .option('useAsyncSmartCode', false)
   .option('settingsTolerance', 2000)
@@ -114,16 +115,22 @@ VWO.prototype.replay = function() {
 VWO.prototype.roots = function() {
   var analytics = this.analytics;
   var self = this;
-
+  var identifyCalled = false;
   rootExperiments(function(err, data) {
     each(data, function(experimentId, variationName) {
+      const uuid = window.VWO.data.vin.uuid;
       var props = {
         experimentId: experimentId,
-        variationName: variationName
+        variationName: variationName,
+        vwoUserId: uuid
       };
 
       if (self.options.experimentNonInteraction) props.nonInteraction = 1;
-
+      
+      if(identifyCalled === false) {
+        analytics.identify({vwoUserId: uuid});
+        identifyCalled = true;
+      }
       analytics.track('Experiment Viewed', props, {
         context: { integration: integrationContext }
       });

integrations/visual-website-optimizer/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@segment/analytics.js-integration-visual-website-optimizer",
   "description": "The Visual Website Optimizer analytics.js integration.",
-  "version": "2.4.1",
+  "version": "2.4.2",
   "keywords": [
     "analytics.js",
     "analytics.js-integration",

integrations/visual-website-optimizer/test/index.test.js

@@ -30,6 +30,13 @@ describe('Visual Website Optimizer', function() {
       }
     };
     window._vis_opt_queue = [];
+    window.VWO = {
+      data: {
+        vin: {
+          uuid: 1
+        }
+      }
+    };
   });
 
   afterEach(function() {
@@ -125,6 +132,7 @@ describe('Visual Website Optimizer', function() {
   describe('#roots', function() {
     beforeEach(function() {
       analytics.stub(analytics, 'track');
+      analytics.stub(analytics, 'identify');
     });
 
     it('should send active experiments if experiment is ready', function(done) {
@@ -134,13 +142,13 @@ describe('Visual Website Optimizer', function() {
 
       tick(function() {
         window._vis_opt_queue[1]();
-
         analytics.called(
           analytics.track,
           'Experiment Viewed',
           {
             experimentId: '1',
-            variationName: 'Variation'
+            variationName: 'Variation',
+            vwoUserId: 1
           },
           {
             context: {
@@ -185,6 +193,44 @@ describe('Visual Website Optimizer', function() {
       });
     });
 
+    it('should send identify call if experiment is ready', function(done) {
+      vwo.options.listen = true;
+      analytics.initialize();
+      analytics.page();
+
+      tick(function() {
+        window._vis_opt_queue[1]();
+        analytics.called(
+          analytics.identify,
+          {
+            vwoUserId: 1
+          }
+        );
+
+        done();
+      });
+    });
+
+    it('should not send identify call if experiment is not ready', function(done) {
+      vwo.options.listen = true;
+      window._vwo_exp[1].ready = false;
+      analytics.initialize();
+      analytics.page();
+
+      tick(function() {
+        window._vis_opt_queue[1]();
+        analytics.didNotCall(
+          analytics.identify,
+          {
+            vwoUserId: 1
+          }
+        );
+
+        done();
+      });
+    });
+
+
     it('should send experiment views as non-interactive if enabled', function(done) {
       vwo.options.listen = true;
       vwo.options.experimentNonInteraction = true;
@@ -200,6 +246,7 @@ describe('Visual Website Optimizer', function() {
           {
             experimentId: '1',
             variationName: 'Variation',
+            vwoUserId: 1,
             nonInteraction: 1
           },
           {
@@ -259,7 +306,8 @@ describe('Visual Website Optimizer', function() {
           'Experiment Viewed',
           {
             experimentId: '1',
-            variationName: 'Variation'
+            variationName: 'Variation',
+            vwoUserId: 1
           },
           {
             context: {