Merge pull request #39 from segment-integrations/niall/catch_null

Catch null products

Author: niallzato

src/main/java/com/segment/analytics/android/integrations/firebase/FirebaseIntegration.java

@@ -211,7 +211,7 @@ && isNullOrEmpty(properties.currency())) {
       } else {
         property = makeKey(property);
       }
-      if (property.equals(Param.ITEMS)) {
+      if (property.equals(Param.ITEMS) && value != null) {
         List<ValueMap> products = properties.getList("products", ValueMap.class);
         ArrayList<Bundle> mappedProducts = formatProducts(products);
         bundle.putParcelableArrayList(property, mappedProducts);

src/test/java/com/segment/analytics/android/integration/firebase/FirebaseTest.java

@@ -152,6 +152,23 @@ public void trackPurchaseWithProducts() {
         verify(firebase).logEvent(eq("purchase"), bundleEq(expected));
     }
 
+    @Test
+    public void trackPurchaseWithNullProducts() {
+        Properties properties = new Properties()
+                .putValue("revenue", 100.0)
+                .putValue("currency", "USD")
+                .putValue("products", null);
+
+        integration.track(new TrackPayload.Builder().anonymousId("1234").properties(properties).event("Order Completed").build());
+
+        Bundle expected = new Bundle();
+        expected.putDouble("value", 100.0);
+        expected.putString("currency", "USD");
+        expected.putString("items", null);
+
+        verify(firebase).logEvent(eq("purchase"), bundleEq(expected));
+    }
+
     @Test
     public void trackWithEventNameTransformation() {
         Properties properties = new Properties()