Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Commit fa5536b

Browse files
committed
#33 Added the why
1 parent 73ff85a commit fa5536b

File tree

1 file changed

+1
-0
lines changed
  • hooks/declarative-subsequent-scans

1 file changed

+1
-0
lines changed

hooks/declarative-subsequent-scans/hook.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ function generateCascadingScanName(
113113
let namePrefix = parentScan.metadata.name;
114114

115115
// 🧙‍ If the Parent Scan start with its scanType we'll replace it with the ScanType of the CascadingScan
116+
// Otherwise scans like nmap-network would have cascading scans like nmap-network-nikto-http-12345 which would be confusing as it is not clear from the name anymore which scanType is actually used.
116117
if (namePrefix.startsWith(parentScan.spec.scanType)) {
117118
namePrefix = namePrefix.replace(
118119
parentScan.spec.scanType,

0 commit comments

Comments
 (0)