Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Commit 6ff9c3d

Browse files
committed
#30 Fixes the headline cases
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
1 parent c87bff9 commit 6ff9c3d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

docs/adr/adr_0001.adoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ To find a proper solution, we splitted the topic into the follwong two questions
4444
. Should we unify the concepts MetaDataProvider and PersistenceProvider?
4545
. How should the execution model look like for each concept?
4646

47-
==== Question 1: Should we unify the concepts MetaDataProvider and PersistenceProvider?
47+
==== Question 1: Should We Unify the Concepts MetaDataProvider and PersistenceProvider?
4848

49-
===== Solution approach 1: Unify
49+
===== Solution Approach 1: Unify
5050

5151
Both "modules" are "processing" the security findings, which are generated in the parsing phase.
5252
But there is one larger difference between them:
@@ -107,7 +107,7 @@ The Execution Flow would then look something like this:
107107
* Need to refactor the ElasticSearch PersistenceProvider
108108
* The "General Implementation" will be harder than the individual ones
109109

110-
===== Solution approach 1: Keep Split between Persistence Provider and MetaData Provider
110+
===== Solution Approach 1: Keep Split between Persistence Provider and MetaData Provider
111111

112112
Keep PersistenceProvider as they are and introduce new "MetaDataProvider" CRD which gets executed before the PersistenceProviders by the operator.
113113

@@ -131,9 +131,9 @@ Keep PersistenceProvider as they are and introduce new "MetaDataProvider" CRD wh
131131

132132
* Really worth introducing a new CRD for everything, especially when the are conceptually pretty close?
133133

134-
==== Question 2: How should the execution model look like for each?
134+
==== Question 2: How Should the Execution Model Look like for Each?
135135

136-
===== Solution approach 1: Like the persistence provider
136+
===== Solution Approach 1: Like the Persistence Provider
137137

138138
Basically a docker container which process takes two command line args:
139139

@@ -159,7 +159,7 @@ Examples:
159159
** ttlAfterFinished enabled
160160
* container runtime overhead (especially time)
161161

162-
=== Option 2: A WebHooks like concept
162+
=== Option 2: A WebHooks Like Concept
163163

164164
Analog to kubernetes webhooks. Https server receiving findings and returning results.
165165

0 commit comments

Comments
 (0)