Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Commit 37448b7

Browse files
committed
Pin Ncrack version to 0.7 for integration Test
1 parent 77dee1c commit 37448b7

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ jobs:
434434
run: |
435435
helm -n integration-tests install ncrack ./scanners/ncrack/ \
436436
--set="parserImage.tag=sha-$(git rev-parse --short HEAD)" \
437-
--set="image.tag=sha-$(git rev-parse --short HEAD)"
437+
--set="image.tag=0.7"
438438
cd tests/integration/
439439
npx jest --ci --color ncrack
440440
- name: "kube-hunter Integration Tests"

scanners/ncrack/templates/ncrack-scan-type.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ spec:
1717
restartPolicy: OnFailure
1818
containers:
1919
- name: ncrack
20-
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.Version }}"
20+
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default 0.7 }}"
2121
command: ["ncrack", "-oX", "/home/securecodebox/ncrack-results.xml"]
2222
resources:
2323
{{- toYaml .Values.scannerJob.resources | nindent 16 }}

scanners/ncrack/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ parserImage:
55

66
image:
77
repository: docker.io/securecodebox/scanner-ncrack
8-
# image.tag - defaults to the charts version
8+
# image.tag - defaults to ncrack version 0.7
99
tag: null
1010

1111
scannerJob:

0 commit comments

Comments
 (0)