Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Commit 02314cf

Browse files
committed
Bugfixing typos and c/p errors.
1 parent be04085 commit 02314cf

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

.github/ISSUE_TEMPLATE/new_hook.md

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,10 @@ Before opening a new issue, please make sure that we do not have any duplicates
2929
Hint: A general guide how to implement a new scanner is documented [here](https://github.com/secureCodeBox/secureCodeBox-v2/tree/master/docs/developer-guide)
3030
-->
3131

32-
- [ ] Create a new folder with the name of the [hook here](https://github.com/secureCodeBox/secureCodeBox-v2/tree/master/scanners), based on the existing template
33-
- [ ] Add a README.md and give a brief overview of the scanner and its configuration options.
34-
- [ ] Implement a new scanner specific scan-type.yaml
35-
- [ ] Implement a new scanner specific parse-definition.yaml
36-
- [ ] Add (optional) some cascading-rules.yaml
37-
- [ ] Add (optional) a Dockerfile for the scanner if there is now existing one public available on dockerHub
38-
- [ ] Use the parserSDK to implement a new findings parser (currently based on NodeJS)
32+
- [ ] Create a new folder with the name of the [hook here](https://github.com/secureCodeBox/secureCodeBox-v2/tree/master/hooks)
33+
- [ ] Add a README and give a brief overview of the scanner and its configuration options.
34+
- [ ] Add (optional) a Dockerfile for the scanner if there is no existing one publicly available on dockerHub
35+
- [ ] Use the [Hook-SDK](https://github.com/secureCodeBox/secureCodeBox-v2/tree/master/hook-sdk) to implement a new hook (currently based on NodeJS)
3936
- [ ] Add unit tests with at minimum 80% test coverage
4037
- [ ] Add some example scan.yaml and finding.yaml files in the example folder
4138
- [ ] Implement a new integration test for the hook [here](https://github.com/secureCodeBox/secureCodeBox-v2/tree/master/tests/integration)

.github/ISSUE_TEMPLATE/new_security_scanner.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,11 @@ Before opening a new issue, please make sure that we do not have any duplicates
2929
Hint: A general guide how to implement a new scanner is documented [here](https://github.com/secureCodeBox/secureCodeBox-v2/tree/master/docs/developer-guide)
3030
-->
3131

32-
- [ ] Create a new folder with the name of the [scanner here](https://github.com/secureCodeBox/secureCodeBox-v2/tree/master/scanners), based on the existing template
32+
- [ ] Create a new folder with the name of the [scanner here](https://github.com/secureCodeBox/secureCodeBox-v2/tree/master/scanners)
3333
- [ ] Add a README.md and give a brief overview of the scanner and its configuration options.
3434
- [ ] Implement a new scanner specific scan-type.yaml
3535
- [ ] Implement a new scanner specific parse-definition.yaml
3636
- [ ] Add (optional) some cascading-rules.yaml
37-
- [ ] Add (optional) a Dockerfile for the scanner if there is now existing one public available on dockerHub
38-
- [ ] Use the parserSDK to implement a new findings parser (currently based on NodeJS)
37+
- [ ] Add (optional) a Dockerfile for the scanner if there is no existing one publicly available on dockerHub
38+
- [ ] Use the [parser-SDK](https://github.com/secureCodeBox/secureCodeBox-v2/tree/master/parser-sdk) to implement a new findings parser (currently based on NodeJS)
3939
- [ ] Add unit tests with at minimum 80% test coverage
40-
- [ ] Add some example scan.yaml and finding.yaml files in the example folder
41-
- [ ] Implement a new integration test for the scanner [here](https://github.com/secureCodeBox/secureCodeBox-v2/tree/master/tests/integration)

0 commit comments

Comments
 (0)