ncrack integration test

Author: sebie

.github/workflows/ci.yaml

@@ -399,11 +399,20 @@ jobs:
           cd tests/integration/
           npx jest --ci --color read-only-hook
           helm -n integration-tests uninstall test-scan http-webhook ro-hook
+      - name: "Install Demo Apps"
+        run: |
+          # Install dummy-ssh app
+          helm -n demo-apps install dummy-ssh ./demo-apps/dummy-ssh/ --wait
       - name: "nmap Integration Tests"
         run: |
           helm -n integration-tests install nmap ./scanners/nmap/ --set="parserImage.tag=sha-$(git rev-parse --short HEAD)"
           cd tests/integration/
           npx jest --ci --color nmap
+      - name: "ncrack Integration Tests"
+        run: |
+          helm -n integration-tests install ncrack ./scanners/ncrack/ --set="parserImage.tag=sha-$(git rev-parse --short HEAD)"
+          cd tests/integration/
+          npx jest --ci --color ncrack
       - name: "kube-hunter Integration Tests"
         run: |
           helm -n integration-tests install kube-hunter ./scanners/kube-hunter/ --set="parserImage.tag=sha-$(git rev-parse --short HEAD)"
@@ -412,8 +421,6 @@ jobs:
       - name: "ssh-scan Integration Tests"
         run: |
           helm -n integration-tests install ssh-scan ./scanners/ssh_scan/ --set="parserImage.tag=sha-$(git rev-parse --short HEAD)"
-          # Install dummy-ssh app
-          helm -n demo-apps install dummy-ssh ./demo-apps/dummy-ssh/ --wait
           cd tests/integration/
           npx jest --ci --color ssh-scan
       - name: Inspect Post Failure

tests/integration/scanner/ncrack.test.js

@@ -0,0 +1,26 @@
+const { scan } = require('../helpers')
+
+test(
+    "localhost port scan should only find a host finding",
+    async () => {
+        const { categories, severities, count } = await scan(
+            "ncrack-dummy-ssh",
+            "ncrack",
+            ["--user", "root,admin", "--pass", "password,123456,THEPASSWORDYOUCREATED", "ssh://dummy-ssh.demo-apps.svc"],
+            90
+        );
+
+        expect(count).toBe(1);
+        expect(categories).toMatchInlineSnapshot(`
+        Object {
+            "Discovered Credentials": 1,
+        }
+        `);
+        expect(severities).toMatchInlineSnapshot(`
+        Object {
+            "high": 1,
+        }
+        `);
+    },
+    3 * 60 * 1000
+);