Even More Integration Tests for EndpointService

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>

Author: Weltraumschaf

src/test/java/io/securecodebox/persistence/defectdojo/service/EndpointServiceTest.java

@@ -3,6 +3,7 @@
 // SPDX-License-Identifier: Apache-2.0
 package io.securecodebox.persistence.defectdojo.service;
 
+import com.fasterxml.jackson.core.JsonProcessingException;
 import io.securecodebox.persistence.defectdojo.model.Endpoint;
 import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
@@ -11,6 +12,7 @@
 import java.net.URISyntaxException;
 import java.util.HashMap;
 
+import static com.github.tomakehurst.wiremock.client.WireMock.equalTo;
 import static com.github.tomakehurst.wiremock.client.WireMock.*;
 import static org.hamcrest.MatcherAssert.assertThat;
 import static org.hamcrest.Matchers.*;
@@ -61,14 +63,13 @@ final class EndpointServiceTest extends WireMockBaseTestCase {
   @Test
   void search() throws URISyntaxException, IOException {
     final var response = readFixtureFile("EndpointService_response_fixture.json");
-    stubFor(
-      get("/api/v2/endpoints/?offset=0&limit=100")
-        .willReturn(
-          ok()
-            .withHeaders(responseHeaders(response.length()))
-            .withBody(response)
-        )
-    );
+    stubFor(get(urlPathEqualTo("/api/v2/endpoints/"))
+      .withQueryParam("limit", equalTo("100"))
+      .withQueryParam("offset", equalTo("0"))
+      .willReturn(ok()
+        .withHeaders(responseHeaders(response.length()))
+        .withBody(response)
+      ));
 
     final var result = sut.search();
 
@@ -81,17 +82,18 @@ void search() throws URISyntaxException, IOException {
   @Test
   void search_withQueryParams() throws URISyntaxException, IOException {
     final var response = readFixtureFile("EndpointService_response_fixture.json");
-    stubFor(
-      get("/api/v2/endpoints/?limit=100&bar=42&offset=0&foo=23")
-        .willReturn(
-          ok()
-            .withHeaders(responseHeaders(response.length()))
-            .withBody(response)
-        )
-    );
+    stubFor(get(urlPathEqualTo("/api/v2/endpoints/"))
+      .withQueryParam("limit", equalTo("100"))
+      .withQueryParam("offset", equalTo("0"))
+      .withQueryParam("foo", equalTo("42"))
+      .withQueryParam("bar", equalTo("23"))
+      .willReturn(ok()
+        .withHeaders(responseHeaders(response.length()))
+        .withBody(response)
+      ));
     final var params = new HashMap<String, Object>();
-    params.put("foo", 23);
-    params.put("bar", 42);
+    params.put("foo", 42);
+    params.put("bar", 23);
 
     final var result = sut.search(params);
 
@@ -125,14 +127,11 @@ void get_byId() {
         "prefetch": {}
       }
       """;
-    stubFor(
-      get("/api/v2/endpoints/42")
-        .willReturn(
-          ok()
-            .withHeaders(responseHeaders(response.length()))
-            .withBody(response)
-        )
-    );
+    stubFor(get(urlPathEqualTo("/api/v2/endpoints/42"))
+      .willReturn(ok()
+        .withHeaders(responseHeaders(response.length()))
+        .withBody(response)
+      ));
     final var expected = Endpoint.builder()
       .id(42)
       .protocol("tcp")
@@ -148,27 +147,124 @@ void get_byId() {
 
 
   @Test
-  @Disabled("TODO: Implement test.")
-  void searchUnique_withSearchObject() {
+  void searchUnique_withSearchObjectWhichReturnsEmptyResult() throws URISyntaxException, JsonProcessingException {
+    // Here we only test that the object properties are correctly mapped to get params,
+    // since the response parsing and binding is covered by the other tests.
+    final var response = """
+      {
+        "count": 0,
+        "next": null,
+        "previous": null,
+        "results": [],
+        "prefetch": {}
+      }
+      """;
+    stubFor(get(urlPathEqualTo("/api/v2/endpoints/"))
+      .withQueryParam("limit", equalTo("100"))
+      .withQueryParam("product", equalTo("285"))
+      .withQueryParam("id", equalTo("42"))
+      .withQueryParam("offset", equalTo("0"))
+      .withQueryParam("port", equalTo("0"))
+      .withQueryParam("mitigated", equalTo("false"))
+      .willReturn(ok()
+        .withHeaders(responseHeaders(response.length()))
+        .withBody(response)
+      ));
+    final var searchObject = Endpoint.builder()
+      .id(42)
+      .product(285)
+      .build();
+
+    final var result = sut.searchUnique(searchObject);
+
+    assertThat(result.isEmpty(), is(true));
   }
 
   @Test
-  @Disabled("TODO: Implement test.")
-  void searchUnique_withQueryParams() {
+  void searchUnique_withQueryParamsWhichReturnsEmptyResult() throws URISyntaxException, JsonProcessingException {
+    // Here we only test that the object properties are correctly mapped to get params,
+    // since the response parsing and binding is covered by the other tests.
+    final var response = """
+      {
+        "count": 0,
+        "next": null,
+        "previous": null,
+        "results": [],
+        "prefetch": {}
+      }
+      """;
+    stubFor(get(urlPathEqualTo("/api/v2/endpoints/"))
+      .withQueryParam("limit", equalTo("100"))
+      .withQueryParam("offset", equalTo("0"))
+      .withQueryParam("foo", equalTo("42"))
+      .withQueryParam("bar", equalTo("23"))
+      .willReturn(ok()
+        .withHeaders(responseHeaders(response.length()))
+        .withBody(response)
+      ));
+    final var queryParams = new HashMap<String, Object>();
+    queryParams.put("foo", 42);
+    queryParams.put("bar", 23);
+
+    final var result = sut.searchUnique(queryParams);
+
+    assertThat(result.isEmpty(), is(true));
   }
 
   @Test
-  @Disabled("TODO: Implement test.")
   void create() {
+    final var expectedRequest = "{\"id\":0,\"protocol\":\"tcp\",\"host\":\"www.owasp.org\",\"port\":443,\"product\":285,\"mitigated\":false}";
+    final var response = "{\"id\":42,\"protocol\":\"tcp\",\"host\":\"www.owasp.org\",\"port\":443,\"product\":285,\"mitigated\":false}";
+
+    stubFor(post(urlPathEqualTo("/api/v2/endpoints/"))
+      .withRequestBody(equalTo(expectedRequest))
+      .willReturn(created()
+        .withHeaders(responseHeaders(response.length()))
+        .withBody(response)
+      ));
+
+    final var endpoint = Endpoint.builder()
+      .protocol("tcp")
+      .host("www.owasp.org")
+      .port(443)
+      .product(285)
+      .build();
+
+    final var result = sut.create(endpoint);
+
+    assertThat(result.getId(), is(42L));
   }
 
   @Test
-  @Disabled("TODO: Implement test.")
-  void delete() {
+  void delete_byId() {
+    stubFor(delete(urlPathEqualTo("/api/v2/endpoints/42/"))
+      .willReturn(ok()));
+
+    sut.delete(42L);
+
+    verify(deleteRequestedFor(urlPathEqualTo("/api/v2/endpoints/42/")));
   }
 
   @Test
-  @Disabled("TODO: Implement test.")
   void update() {
+    final var json = "{\"id\":42,\"protocol\":\"tcp\",\"host\":\"www.owasp.org\",\"port\":443,\"product\":285,\"mitigated\":false}";
+    stubFor(put(urlPathEqualTo("/api/v2/endpoints/42/"))
+      .withRequestBody(equalTo(json))
+      .willReturn(ok()
+        .withHeaders(responseHeaders(json.length()))
+        .withBody(json)
+      ));
+
+    final var endpoint = Endpoint.builder()
+      .id(42)
+      .protocol("tcp")
+      .host("www.owasp.org")
+      .port(443)
+      .product(285)
+      .build();
+
+    final var updated = sut.update(endpoint, 42L);
+
+    assertThat(updated, is(endpoint));
   }
 }