#36 Decompose method to make code testable

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>

Author: Weltraumschaf

src/main/java/io/securecodebox/persistence/defectdojo/http/Foo.java

@@ -61,13 +61,10 @@ static String encodeProxyCredentials(@NonNull final ProxyConfig cfg) {
     public RestTemplate createRestTemplate() {
         if (proxyConfig.isComplete()) {
             // Configuring Proxy Authentication explicitly as it isn't done by default for spring rest templates :(
-            final var credentials = new BasicCredentialsProvider();
-            credentials.setCredentials(createAuthScope(), createCredentials());
-
             final var builder = HttpClientBuilder.create();
             builder.useSystemProperties();
             builder.setProxy(createHttpHost());
-            builder.setDefaultCredentialsProvider(credentials);
+            builder.setDefaultCredentialsProvider(createCredentialsProvider());
             builder.setProxyAuthenticationStrategy(new ProxyAuthenticationStrategy());
 
             final var factory = new HttpComponentsClientHttpRequestFactory();
@@ -78,6 +75,12 @@ public RestTemplate createRestTemplate() {
         return new RestTemplate();
     }
 
+    CredentialsProvider createCredentialsProvider() {
+        final var provider = new BasicCredentialsProvider();
+        provider.setCredentials(createAuthScope(), createCredentials());
+        return provider;
+    }
+
     AuthScope createAuthScope() {
         return new AuthScope(proxyConfig.getHost(), proxyConfig.getPort());
     }

src/test/java/io/securecodebox/persistence/defectdojo/http/FooTest.java

@@ -68,6 +68,17 @@ void encodeProxyCredentials() {
         assertThat(Foo.encodeProxyCredentials(proxyConfig), is("YsOkcnRyYW06Z29oemU4QWU="));
     }
 
+    @Test
+    void createCredentialsProvider() {
+        final var result = sut.createCredentialsProvider();
+        final var credentials = result.getCredentials(sut.createAuthScope());
+
+        assertAll(
+                () -> assertThat(credentials.getUserPrincipal().getName(), is(proxyConfig.getUser())),
+                () -> assertThat(credentials.getPassword(), is(proxyConfig.getPassword()))
+        );
+    }
+
     @Test
     void createAuthScope() {
         final var result = sut.createAuthScope();