Performance optimizations around UI

- various improvements
- lazily creates the UI wigets for categories when their parent is expanded

Author: rohvani

indra/llcommon/llsingleton.h

@@ -522,13 +522,16 @@ class LLSingleton : public LLSingletonBase
             case INITIALIZING:
                 // here if DERIVED_TYPE::initSingleton() (directly or indirectly)
                 // calls DERIVED_TYPE::getInstance(): go ahead and allow it
-            case INITIALIZED:
-                // normal subsequent calls
-                // record the dependency, if any: check if we got here from another
+                // record the dependency: check if we got here from another
                 // LLSingleton's constructor or initSingleton() method
                 capture_dependency(lk->mInstance);
                 return lk->mInstance;
 
+            case INITIALIZED:
+                // normal subsequent calls - skip capture_dependency() for performance
+                // dependencies are only tracked during initialization
+                return lk->mInstance;
+
             case DELETED:
                 // called after deleteSingleton()
                 logwarns({"Trying to access deleted singleton ",
@@ -728,12 +731,14 @@ class LLParamSingleton : public LLSingleton<DERIVED_TYPE>
 
         case super::INITIALIZING:
             // As with LLSingleton, explicitly permit circular calls from
-            // within initSingleton()
-        case super::INITIALIZED:
-            // for any valid call, capture dependencies
+            // within initSingleton() and capture dependencies
             super::capture_dependency(lk->mInstance);
             return lk->mInstance;
 
+        case super::INITIALIZED:
+            // normal subsequent calls - skip capture_dependency() for performance
+            return lk->mInstance;
+
         case super::DELETED:
             super::logerrs({"Trying to access deleted param singleton ",
                            super::template classname<DERIVED_TYPE>()});

indra/llui/llpanel.cpp

@@ -489,58 +489,70 @@ bool LLPanel::initPanelXML(LLXMLNodePtr node, LLView *parent, LLXMLNodePtr outpu
         LL_RECORD_BLOCK_TIME(FTM_PANEL_SETUP);
 
         LLXMLNodePtr referenced_xml;
-        std::string xml_filename = mXMLFilename;
+        const std::string& xml_filename = mXMLFilename;
 
         // if the panel didn't provide a filename, check the node
         if (xml_filename.empty())
         {
-            node->getAttributeString("filename", xml_filename);
-            setXMLFilename(xml_filename);
+            std::string temp_filename;
+            node->getAttributeString("filename", temp_filename);
+            setXMLFilename(temp_filename);
         }
 
+        // Cache singleton and filename to avoid repeated calls
+        LLUICtrlFactory* factory = LLUICtrlFactory::getInstance();
+
+        // Cache node name pointer to avoid repeated dereferencing
+        const LLStringTableEntry* node_name = node->getName();
+
+        // Cache registry to avoid repeated singleton access
+        const child_registry_t& registry = child_registry_t::instance();
+
         LLXUIParser parser;
 
-        if (!xml_filename.empty())
+        if (!mXMLFilename.empty())
         {
             if (output_node)
             {
                 //if we are exporting, we want to export the current xml
                 //not the referenced xml
-                parser.readXUI(node, params, LLUICtrlFactory::getInstance()->getCurFileName());
+                parser.readXUI(node, params, factory->getCurFileName());
                 Params output_params(params);
                 setupParamsForExport(output_params, parent);
-                output_node->setName(node->getName()->mString);
+                output_node->setName(node_name->mString);
                 parser.writeXUI(output_node, output_params, LLInitParam::default_parse_rules(), &default_params);
                 return true;
             }
 
-            LLUICtrlFactory::instance().pushFileName(xml_filename);
+            factory->pushFileName(mXMLFilename);
 
             LL_RECORD_BLOCK_TIME(FTM_EXTERNAL_PANEL_LOAD);
-            if (!LLUICtrlFactory::getLayeredXMLNode(xml_filename, referenced_xml))
+            if (!LLUICtrlFactory::getLayeredXMLNode(mXMLFilename, referenced_xml))
             {
-                LL_WARNS() << "Couldn't parse panel from: " << xml_filename << LL_ENDL;
+                LL_WARNS() << "Couldn't parse panel from: " << mXMLFilename << LL_ENDL;
 
                 return false;
             }
 
-            parser.readXUI(referenced_xml, params, LLUICtrlFactory::getInstance()->getCurFileName());
+            // Get filename after pushFileName
+            const std::string& updated_filename = factory->getCurFileName();
+            parser.readXUI(referenced_xml, params, updated_filename);
 
             // add children using dimensions from referenced xml for consistent layout
             setShape(params.rect);
-            LLUICtrlFactory::createChildren(this, referenced_xml, child_registry_t::instance());
+            LLUICtrlFactory::createChildren(this, referenced_xml, registry);
 
-            LLUICtrlFactory::instance().popFileName();
+            factory->popFileName();
         }
 
         // ask LLUICtrlFactory for filename, since xml_filename might be empty
-        parser.readXUI(node, params, LLUICtrlFactory::getInstance()->getCurFileName());
+        parser.readXUI(node, params, factory->getCurFileName());
 
         if (output_node)
         {
             Params output_params(params);
             setupParamsForExport(output_params, parent);
-            output_node->setName(node->getName()->mString);
+            output_node->setName(node_name->mString);
             parser.writeXUI(output_node, output_params, LLInitParam::default_parse_rules(), &default_params);
         }
 
@@ -552,7 +564,7 @@ bool LLPanel::initPanelXML(LLXMLNodePtr node, LLView *parent, LLXMLNodePtr outpu
         }
 
         // add children
-        LLUICtrlFactory::createChildren(this, node, child_registry_t::instance(), output_node);
+        LLUICtrlFactory::createChildren(this, node, registry, output_node);
 
         // Connect to parent after children are built, because tab containers
         // do a reshape() on their child panels, which requires that the children

indra/llui/llview.cpp

@@ -305,6 +305,12 @@ bool LLView::addChild(LLView* child, S32 tab_group)
     // add to front of child list, as normal
     mChildList.push_front(child);
 
+    // Add to name cache for fast lookup
+    if (!child->getName().empty())
+    {
+        mChildNameCache[child->getName()] = child;
+    }
+
     // add to tab order list
     if (tab_group != 0)
     {
@@ -344,6 +350,13 @@ void LLView::removeChild(LLView* child)
         // if we are removing an item we are currently iterating over, that would be bad
         llassert(!child->mInDraw);
         mChildList.remove( child );
+
+        // Remove from name cache
+        if (!child->getName().empty())
+        {
+            mChildNameCache.erase(child->getName());
+        }
+
         child->mParentView = NULL;
         child_tab_order_t::iterator found = mTabOrder.find(child);
         if (found != mTabOrder.end())
@@ -1649,15 +1662,25 @@ LLView* LLView::findChildView(std::string_view name, bool recurse) const
 {
     LL_PROFILE_ZONE_SCOPED_CATEGORY_UI;
 
+    // Check cache first for direct children - O(1) lookup instead of O(n)
+    auto cache_it = mChildNameCache.find(name);
+    if (cache_it != mChildNameCache.end())
+    {
+        return cache_it->second;
+    }
+
     // Look for direct children *first*
     for (LLView* childp : mChildList)
     {
         llassert(childp);
         if (childp->getName() == name)
         {
+            // Cache the result for next lookup
+            mChildNameCache[name] = childp;
             return childp;
         }
     }
+
     if (recurse)
     {
         // Look inside each child as well.

indra/llui/llview.h

@@ -589,6 +589,9 @@ class LLView
     LLView*     mParentView;
     child_list_t mChildList;
 
+    // Cache for fast child lookup by name - O(1) instead of O(n)
+    mutable std::unordered_map<std::string_view, LLView*> mChildNameCache;
+
     // location in pixels, relative to surrounding structure, bottom,left=0,0
     bool        mVisible;
     LLRect      mRect;